feat: Exclude minted drop email reservations in total count #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poap-sdk canceled.
|
jm42
approved these changes
Jul 15, 2024
reobin
force-pushed
the
feat/email-reservations-count
branch
from
6d7b92a to
390858f
Compare
reobin
force-pushed
the
feat/email-reservations-count
branch
from
390858f to
4cc4703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The email reservation count for a drop includes reservations that have been minted already, and therefore skews the total collectors count in place where you want to do:
mint count + reservation count = total collectors count.A possibility is to keep both counts (minted and reserved), and choose which is preferred on each client. Worth discussing if we think that's needed.