Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor types and exports #128

Merged
merged 12 commits into from
Jun 27, 2024
Merged

Refactor types and exports #128

merged 12 commits into from
Jun 27, 2024

Conversation

jm42
Copy link
Member

@jm42 jm42 commented Jun 27, 2024

Description

Small refactor that removes the files with many exports and organizes what the library exports to be more consistent between libraries. Removes old @poap-xyz/poaps documentation. Moves mapping to domain objects.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.

@jm42 jm42 requested review from nacho9900 and rlajous June 27, 2024 18:13
@jm42 jm42 self-assigned this Jun 27, 2024
Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for poap-sdk ready!

Name Link
🔨 Latest commit fd91fb2
🔍 Latest deploy log https://app.netlify.com/sites/poap-sdk/deploys/667dabc8c48efe0008ce8196
😎 Deploy Preview https://deploy-preview-128--poap-sdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jm42 jm42 removed the request for review from nacho9900 June 27, 2024 19:04
@jm42 jm42 merged commit 2ca7f8d into main Jun 27, 2024
5 checks passed
@jm42 jm42 deleted the refactor-types-and-exports branch June 27, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants