Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OrderBy type recursive #114

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Make OrderBy type recursive #114

merged 2 commits into from
Apr 19, 2024

Conversation

jm42
Copy link
Member

@jm42 jm42 commented Apr 18, 2024 •
edited
Loading

Description

Make OrderBy recursive.

Related to #113

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.

@jm42 jm42 requested review from reobin and rlajous April 18, 2024 07:10
@jm42 jm42 self-assigned this Apr 18, 2024
@jm42 jm42 mentioned this pull request Apr 18, 2024
Closed
@netlify Netlify
Copy link

netlify bot commented Apr 18, 2024 •
edited
Loading

✅ Deploy Preview for poap-sdk canceled.

Name Link
🔨 Latest commit d5b0db0
🔍 Latest deploy log https://app.netlify.com/sites/poap-sdk/deploys/6620c8b3ee23690008876db9

@jm42 jm42 merged commit ad3d559 into main Apr 19, 2024
5 checks passed
@jm42 jm42 deleted the fix-order-by-type branch April 19, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlajous rlajous rlajous approved these changes

@reobin reobin Awaiting requested review from reobin

Assignees

@jm42 jm42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jm42 @rlajous