(Feature) Apply new design to step 4: "Publish" #1204

gabitoesmiapodo · 2018-10-29T19:42:24Z

Description:

Here's the implementation of Step 4's styles.

There are some changes to the original designs (fields' order, added TxStatus elements) in the hopes of making everything clearer and easier to the end user.

Screenshots:

…g-#1083

(Feature) Add assets to support new design

(feat) Loading component (feat) Home page modal (in progress)

…sign-landing-page * integration/#1082-new-design: new source of e2e-test: branch 2.0-newDesign

* 2.0: Remove ABI source code Remove bin from summary Add Proxy Contract contents

* 2.0: Set ABI-Encoded Params to Proxy constructor params Add ABI-Encoded params

* 2.0: Add proxyName, compiler version and optimization info

* 2.0: (171 commits) Remove conditional Add source code of smart proxy contract to zip archive for download Change how validate params and network id Check crowdsale env vars by crowdsale type Added new contracts keys to file Remove unused function Refactoring function Update snapshot Reload storage on home Change label on content file Add function import Sort crowdsales list Add clear storage on manage section Add alert info if contracts already deployed Update snapshot Change how gas type is set Validate network change Disable supply input on dutch strategy Supply disable Fix getAddr ... # Conflicts: # package.json # src/components/Home/index.js # src/components/stepFour/index.js # src/components/stepOne/index.js # src/components/stepThree/index.js

…-new-design-step-1 * feature/#1084-new-design-landing-page: (179 commits) (fix) Firefox button borders. (feedback) Various fixes and changes from #1122 Remove conditional Add proxyName, compiler version and optimization info Set ABI-Encoded Params to Proxy constructor params Add source code of smart proxy contract to zip archive for download Change how validate params and network id Check crowdsale env vars by crowdsale type Add ABI-Encoded params Added new contracts keys to file Remove unused function Refactoring function Update snapshot Reload storage on home Remove ABI source code Change label on content file Remove bin from summary Add function import Sort crowdsales list Add clear storage on manage section ... # Conflicts: # src/assets/stylesheets/styles.css

- added method to handle navigation to facilitate testing

…-new-design-step-1 * feature/#1084-new-design-landing-page: Add tests for Home component - added method to handle navigation to facilitate testing Add jest-localstorage-mock as dev-dependency Update CrowdsaleList component tests Update Loader component tests Remove unused components and its tests (fix) Small layout / modal CSS fix. # Conflicts: # package.json # src/assets/stylesheets/styles.css

…ding-page (Feature) New design for home / landing page

* 2.0: Remove unused scripts Fix typo Add metadata to file

vbaranov

@gabitoesmiapodo

column with tx status is not fixed. It is moving depending on the length of the current status message. Could we fix it?
There is no response on copy action. Could we add a tooltip?
the same:

dennis00010011b · 2018-10-30T17:13:56Z

@gabitoesmiapodo
Multitiers crowdsale: only Tier1 column is displayed in modal.

dennis00010011b · 2018-10-30T17:45:03Z

@gabitoesmiapodo
Extra title, shouldn't be here

dennis00010011b · 2018-10-30T18:02:24Z

@gabitoesmiapodo
Typo in Step3

dennis00010011b · 2018-10-30T18:23:58Z

@gabitoesmiapodo
Dutch: tier 's info is placed in chaotic order. Would be better:
Start time - End Time
Global min cap - max cap
Min rate - max rate
Enable whitelisting

…new-design-to-step-4-publish * integration/#1082-new-design: Added tests to webStore, and fake provider Remove try catch and fix linter WIP tests Refactoring Update link Refactoring Refactoring Remove spec Move switch , remove load Update DApp loading code considering upcoming breaking change in metaMask Set default custom price Check if address is changed

gabitoesmiapodo · 2018-10-31T20:00:51Z

@vbaranov

1- column with tx status is not fixed. It is moving depending on the length of the current status message. Could we fix it? -> The "Tx Name" column's width is now fixed, so no columns should move now. I don't know if there's a better fix for this, other than changing how this information is shown.

2- There is no response on copy action. Could we add a tooltip? -> Yeah, now a message is shown when the user clicks on this.

3- Text in one line -> Sure. I think there was a mistake and some text got repeated.

4- Text in one line for wallet addres -> Sure, but for "Whitelist with cap" only, because there's a column for "Burn excess" next to in "Dutch Auction".

@dennis00010011b

Multitiers crowdsale: only Tier1 column is displayed in modal. -> I think only first tier and tiers with a whitelist are displayed (maybe someone can confirm this?)

dennis00010011b · 2018-11-01T02:15:30Z

@gabitoesmiapodo

Yes, you are right

Multitiers crowdsale: only Tier1 column is displayed in modal. -> I think only first tier and tiers with a whitelist are displayed (maybe someone can confirm this?)

2.There is no modal in Step 4 after this commit 6ba5737

gabitoesmiapodo · 2018-11-01T19:58:25Z

@dennis00010011b

1- Extra title, shouldn't be here

Removed.

2- Typo in Step3

Fixed.

3- Dutch: tier 's info is placed in chaotic order. Would be better:

Start time      ---- End Time
Global min cap  ---- max cap
Min rate        ---- max rate
Enable whitelisting

Fixed.

4- There is no modal in Step 4 after this commit 6ba5737

Yeah, now it's back.

dennis00010011b · 2018-11-01T22:58:14Z

@gabitoesmiapodo
LGTM, except two things:

I still cannot compile build on MacOS unless to rename folder from src/components/crowdsale to src/components/Crowdsale`
(Feature) Apply new design to step 5: "Crowdsale page" #1206 (comment)
Should be mentioned about all tiers in modal? Example, crowdsale has 3 tiers: 1&3 without whitelist, 2nd whiteist, as a result the Tier3 isn't displayed. Would be better to group no-whitelisted tiers together?

gabitoesmiapodo · 2018-11-02T17:43:12Z

@dennis00010011b

I still cannot compile build on MacOS unless to rename folder from src/components/crowdsale to src/components/Crowdsale

I used another way to change the files / folders' names on MacOS and have them recognized by Git, please have a look now.

Should be mentioned about all tiers in modal? Example, crowdsale has 3 tiers: 1&3 without whitelist, 2nd whiteist, as a result the Tier3 isn't displayed. Would be better to group no-whitelisted tiers together?

We should ask @vbaranov or maybe @fernandomg about this. I'm not particularly fond about the way this information is displayed now, for several reasons: It's not clear that only tiers with a whitelist are included, tiers' names aren't displayed, I can't cancel or leave this section if something goes wrong (or if I just want to), and generally speaking It's not always clear what's going on (to me at least).

Maybe we should just add a short text clarifying that only tiers' with a whitelist are included here? That would be a small improvement, but I'm not sure if that's really the problem.

I created an issue with a proposal of what I think would be a better way to display all this information to the user: #1208

fernandomg · 2018-11-02T21:01:28Z

@gabitoesmiapodo I just added a fix to eliminate the duplicated in-progress button

The rest looks fantastic.

gabitoesmiapodo and others added 30 commits August 30, 2018 14:03

Merge remote-tracking branch 'upstream/2.0' into feature/2.0-restylin…

f442612

…g-#1083

(fix) revert styling temporarily.

2927f0f

(feature) landing page desktop styles

cbd65bc

new source of e2e-test: branch 2.0-newDesign

2f4d9e3

Merge pull request #1119 from poanetwork/feature/#1083-2.0-restyling

3285a18

(Feature) Add assets to support new design

(feat) Home page - desktop and responsive styles

5a4d455

(feat) Loading component (feat) Home page modal (in progress)

(feature) Landing / home page styles.

c427090

(chore) Deleted comment.

1dcbc6f

Merge branch 'integration/#1082-new-design' into feature/#1084-new-de…

bffc5eb

…sign-landing-page * integration/#1082-new-design: new source of e2e-test: branch 2.0-newDesign

(feat) Added white POA Token Wizard logo.

8797b2b

Merge branch '2.0' into feature/#1085-new-design-landing-page_merge

931c4b1

* 2.0: Remove ABI source code Remove bin from summary Add Proxy Contract contents

Merge branch '2.0' into feature/#1085-new-design-landing-page_merge

b1f8576

* 2.0: Set ABI-Encoded Params to Proxy constructor params Add ABI-Encoded params

Merge branch '2.0' into feature/#1085-new-design-landing-page_merge

0b162d3

* 2.0: Add proxyName, compiler version and optimization info

(feedback) Various fixes and changes from #1122

c01a3d8

(fix) Firefox button borders.

987a3cc

(chore) Generated styles.css.

f7c9671

(fix) Small layout / modal CSS fix.

33dee7d

Remove unused components and its tests

7604441

Update Loader component tests

1d5d50f

Update CrowdsaleList component tests

a13efeb

Add jest-localstorage-mock as dev-dependency

85b8aad

Add tests for Home component

6ff3278

- added method to handle navigation to facilitate testing

Merge pull request #1122 from poanetwork/feature/#1084-new-design-lan…

c6e2103

…ding-page (Feature) New design for home / landing page

Merge branch '2.0' into feature/#1085-new-design-step-1

5d4721f

* 2.0: Remove unused scripts Fix typo Add metadata to file

(feat) Steps' circles container mobile.

818d65b

(feat) Step layout.

82df042

(feature) Step content container mobile / desktop.

67616cb

gabitoesmiapodo added 2 commits October 29, 2018 17:07

(fix) alert timeout

26d6503

(fix) small visual update

87943f8

vbaranov reviewed Oct 30, 2018

View reviewed changes

gabitoesmiapodo added 3 commits October 31, 2018 15:16

(fix) import files' names

af149d9

(fix) Step 4 feedback.

6ba5737

(fix) step 4 PR feedback

e420b80

gabitoesmiapodo added 2 commits November 2, 2018 08:22

(fix) trying to fix folder name's case in macos

972f154

(fix) folder name's case fix

d376523

Remove duplicated clocks on active tx row

47bf4ce

ghost assigned fernandomg Nov 2, 2018

fernandomg approved these changes Nov 2, 2018

View reviewed changes

dennis00010011b approved these changes Nov 2, 2018

View reviewed changes

gabitoesmiapodo merged commit 8ce74cd into integration/#1082-new-design Nov 5, 2018

ghost removed the in progress label Nov 5, 2018

gabitoesmiapodo deleted the feature/#1088-apply-new-design-to-step-4-publish branch November 5, 2018 10:52

This was referenced Apr 27, 2021

[Snyk] Fix for 1 vulnerabilities larrycameron80/token-wizard#20

Open

[Snyk] Fix for 1 vulnerabilities kinexis-uk/token-wizard#18

Open

kinexis-uk mentioned this pull request Oct 1, 2023

[Snyk] Fix for 1 vulnerabilities kinexis-uk/token-wizard#46

Open

larrycameron80 mentioned this pull request Oct 2, 2023

[Snyk] Fix for 1 vulnerabilities larrycameron80/token-wizard#46

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(Feature) Apply new design to step 4: "Publish" #1204

(Feature) Apply new design to step 4: "Publish" #1204

gabitoesmiapodo commented Oct 29, 2018 •

edited

Loading

vbaranov left a comment •

edited

Loading

dennis00010011b commented Oct 30, 2018

dennis00010011b commented Oct 30, 2018

dennis00010011b commented Oct 30, 2018

dennis00010011b commented Oct 30, 2018 •

edited

Loading

gabitoesmiapodo commented Oct 31, 2018

dennis00010011b commented Nov 1, 2018

gabitoesmiapodo commented Nov 1, 2018

dennis00010011b commented Nov 1, 2018 •

edited

Loading

gabitoesmiapodo commented Nov 2, 2018

fernandomg commented Nov 2, 2018

(Feature) Apply new design to step 4: "Publish" #1204

(Feature) Apply new design to step 4: "Publish" #1204

Conversation

gabitoesmiapodo commented Oct 29, 2018 • edited Loading

vbaranov left a comment • edited Loading

Choose a reason for hiding this comment

dennis00010011b commented Oct 30, 2018

dennis00010011b commented Oct 30, 2018

dennis00010011b commented Oct 30, 2018

dennis00010011b commented Oct 30, 2018 • edited Loading

gabitoesmiapodo commented Oct 31, 2018

dennis00010011b commented Nov 1, 2018

gabitoesmiapodo commented Nov 1, 2018

dennis00010011b commented Nov 1, 2018 • edited Loading

gabitoesmiapodo commented Nov 2, 2018

fernandomg commented Nov 2, 2018

gabitoesmiapodo commented Oct 29, 2018 •

edited

Loading

vbaranov left a comment •

edited

Loading

dennis00010011b commented Oct 30, 2018 •

edited

Loading

dennis00010011b commented Nov 1, 2018 •

edited

Loading