(Fix) Update package.json and fix a few scripts #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbaranov
reviewed
May 30, 2019
| votingPage.fillLicenseID(validatorMetaData.license_id); | ||
| votingPage.fillLicenseExpiration(validatorMetaData.license_expiration); | ||
| votingPage.fillState(validatorMetaData.us_state); | ||
| //votingPage.fillFullName(validatorMetaData.full_name); |
There was a problem hiding this comment.
@varasev was commenting intentional? I didn't find the description of it in the PR
There was a problem hiding this comment.
Yes, all the changes in this PR are intentional. I commented out these lines because of poanetwork/poa-dapps-voting#198. Updated the description ☝️
phahulin
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Mandatory) Description
This PR updates the commit hashes in the
package.jsonfor DApps and fixes a few scripts:e2eGovernanceTest.jswas updated to make it work with theVoting DAppmodified by (Fix) Temporarily remove Validator fields from theNew Ballotpage poa-dapps-voting#198pages/Voting.jswas fixed because the XPath for theAdd Ballotbutton was changed in the Voting DAppscripts/start-moc-nodeandscripts/start-validator-nodewere updated because they didn't redirect Parity's output to the log file(Mandatory) What is it: (Fix), (Feature) or (Refactor)
(Fix)