Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix example minimal local debug config #2948

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

krystianfowler
Copy link
Contributor

@krystianfowler krystianfowler commented Feb 27, 2024

Category

  • Bug fix?
  • New feature?
  • New sample?
  • Documentation update?

What's in this Pull Request?

Setting up the repository for the first time I noticed that using the minimal settings from the current docs gives the following error:

  1. "before all" hook: setup in "{root}":
    ReferenceError: module is not defined in ES module scope
    This file is being treated as an ES module because it has a '.js' file extension and '/Users/krystianfowler/projects/pnpjs/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
    at file:///Users/krystianfowler/projects/pnpjs/settings.js:72:1
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25)

This PR converts the minimal settings example to ES module so that the issue above doesn't occur.

@patrick-rodgers
Copy link
Member

Can you share the steps to repro the issue you aim to fix with this PR?

@bcameron1231
Copy link
Collaborator

Thank you!

@bcameron1231 bcameron1231 merged commit 4a19bfa into pnp:version-3 Mar 4, 2024
1 check passed
@bcameron1231 bcameron1231 added this to the 3.24.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants