Fix: fromAbsolutePath methods reference undefined this
#2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoelVB
changed the title
thisthis
|
Thanks for submitting this fix! Can't believe no one caught it before, appreciate you taking the time to create the PR. Fix will go out in tonight's nightly build as well as the release planned for Jan 15th. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
Related Issues
No related issue.
When creating a File/Folder object based on the absolute path you would get the error:
Cannot read property '_url' of undefined, because theinitvalue here would beundefined:pnpjs/packages/queryable/queryable.ts
Lines 80 to 81 in e62c30d
What's in this Pull Request?
The methods
fileFromAbsolutePath/folderFromAbsolutePathnow use thebaseargument