Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Caching and Pagination Logic #2841

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Conversation

bcameron1231
Copy link
Collaborator

@bcameron1231 bcameron1231 commented Nov 28, 2023

Add a new RawData event which returns the un-parsed raw response in Queryable
Update Caching Behavior to hook into rawData event to set cached data
Update Caching Behavior to override send with cached response
Fix Tests

Category

  • Bug fix?
  • New feature?
  • New sample?
  • Documentation update?

Related Issues

fixes #2836

What's in this Pull Request?

Update to caching and queryable behavior to handle raw/unparsed data. Working with unparsed data allows us to store annotations and properties required for paginating (such as odata.nextLink) parsers.

Add a new RawData event which returns the un-parsed raw response in Queryable
Update Caching Behavior to hook into rawData event to set cached data
Update Caching Behavior to override send with cached response
@bcameron1231
Copy link
Collaborator Author

Please review before merging :)

@bcameron1231 bcameron1231 modified the milestones: 3.210, 3.21.0 Nov 30, 2023
@juliemturner juliemturner merged commit ec2f5d6 into pnp:version-3 Dec 4, 2023
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combination of Caching and Paging does not work correctly
2 participants