Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGT login sample in React #20

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

GuidoZam
Copy link
Contributor

Q A
Bug fix? no
New feature? no
New sample? yes

What's in this Pull Request?

Added a sample about using the Login control in a SPFx solution.

Copy link

Validation failed!

File: samples/app/react-login-spfx/assets/sample.json

  • Invalid url for thumbnail Typos checks #1 property: The provided URL is not responding correctly!

Copy link
Collaborator

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This looks great! Want to get a final approval from our code wizard @gavinbarron before we merge!

Copy link
Collaborator

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

LGTM!

@gavinbarron gavinbarron merged commit f0c36be into pnp:main Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants