Adds 'spe container get' command. Closes #6083 #6421

nanddeepn · 2024-10-09T17:30:31Z

Adds spe container get command. Closes #6083

milanholemans · 2024-10-09T18:05:58Z

Thank you, we'll try to review it ASAP!

milanholemans · 2024-10-09T18:09:08Z

Hi @nanddeepn, just to inform you, when developing new commands, we require all new commands to use ZOD instead of the old implementation. ZOD simplifies validating options and setting up telemetry.
If you're looking for examples, you can check login, flow recyclebinitem restore, flow recyclebinitem list and few other commands. So next time, please, use the new ZOD approach, thanks!

Adam-it · 2024-10-29T10:56:50Z

@nanddeepn I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩

Adam-it

@nanddeepn Awesome work so far 👏👏👏
I noticed some few minor details we could sort out before we merge 👍.
Also along the way may I kindly ask you to rebase with latest main before we proceed 👍
Thank you for your awesome work. You Rock 🤩

src/m365/spe/commands/container/container-get.spec.ts

Adam-it · 2024-11-20T22:32:38Z

src/m365/spe/commands/container/container-get.ts

+    };
+
+    try {
+      const res = await request.get<any>(requestOptions);


can we use the ContainerProperties interface here instead of any?

…np#6357

…#6143

…pnp#5998

…oses pnp#6158

…loses pnp#6419

pnp#6443

…6430

…ft365 into issue-6083

Adam-it

LGTM 👍
Awesome work 👏👏

Adam-it · 2024-11-25T21:10:40Z

Ready to merge 🚀

Adam-it · 2024-11-26T04:26:09Z

@nanddeepn I tried to merge this one but I had a really hard time doing so due to almost 40 commits that are not part of this change 😮.
I think something got wrong when you rebased this branch against main 🤔.
May I kindly ask you to try to rebase it again or open a new PR with your changes and just tag me over in that one so that it will get me unblocked to move forward with this change? 🙏
Sorry for the inconvenience

Adam-it · 2024-11-26T08:43:44Z

@pnp/cli-for-microsoft-365-maintainers due to my short brake I am unassigning myself from this one so that it may be processed by someone else

nanddeepn · 2024-11-28T10:34:36Z

Hi @Adam-it
I have raised a new PR at #6507
Closing this one. Please review.

Adam-it · 2024-11-28T11:00:14Z

Hi @Adam-it
I have raised a new PR at #6507
Closing this one. Please review.

Thank you for letting me know. I will let the team know that this PR is ready to be merged and someone else will process it as in December I will be on a short break from this repo.
Unfortunately it will be very hard for me to find even 10 min time for activities in this project during this month ☹️

nanddeepn · 2024-11-28T11:03:29Z

Hi @Adam-it
I have raised a new PR at #6507
Closing this one. Please review.

Thank you for letting me know. I will let the team know that this PR is ready to be merged and someone else will process it as in December I will be on a short break from this repo. Unfortunately it will be very hard for me to find even 10 min time for activities in this project during this month ☹️

Totally understand, and I appreciate your efforts so far. Enjoy your well-deserved break!

Adam-it · 2024-11-28T11:07:23Z

Totally understand, and I appreciate your efforts so far. Enjoy your well-deserved break!

Thanks 🤩😍.
Unfortunately it's not a break but I will be super engaged in other work and I will simply have even less time then usual 😅

Adam-it added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2024

Adam-it self-assigned this Nov 20, 2024

Adam-it requested changes Nov 20, 2024

View reviewed changes

Adam-it marked this pull request as draft November 20, 2024 22:35

spe container get

ff8cbad

nanddeepn force-pushed the issue-6083 branch from 8a40df8 to ff8cbad Compare November 25, 2024 15:43

nanddeepn and others added 21 commits November 25, 2024 15:45

review comments

486deaf

Merge branch 'main' into issue-6083

330ba95

Moves 'spo folder copy' to new endpoint. Closes pnp#6310

d233e8c

Removes deprecated option from 'entra m365group user remove'. Closes p…

def156c

…np#6357

Updates 'spo userprofile get' command docs.

4bd7faa

Updates release notes

c6297ed

Adds new command 'spo page publish'. Closes pnp#6420

bc324dc

Updates release notes

563ff82

Renames command 'spo site list' to 'spo tenant site list'. Closes pnp…

cb46a5e

…#6143

Adds command 'viva engage community user list'. Closes pnp#6295

8fde5f4

Adds command 'spo folder sharinglink set'. Closes pnp#5964

7668a3b

Updates release notes

f991f0c

Updates 'teams cache remove' command to support the new client. Closes …

74c7a94

…pnp#5998

Updates release notes

7e0914e

Updates version to v10.1.0

9f71bd6

Adds command 'm365 spe container list'. Closes pnp#6082

15d55a1

Adds command 'spe containertype get'. Closes pnp#5991

52f2eaa

Fixes using env var for login command. Closes pnp#6469

0d10ddc

Updates v10 upgrade guidance. Closes pnp#6363

f32e5f1

Updates release notes

fc5c2f7

Fixes missing 'sp' alias in 'enterpriseapp' commands. Closes pnp#6476

c94236f

MathijsVerbeeck and others added 17 commits November 25, 2024 17:35

Enhances spo contenttype commands with Parent expand. Closes pnp#6329

d90637c

Updates the docs on how to log in to CLI. Closes pnp#6343

4bf19f4

Enhances 'graph subscription add' command with additional options. Cl…

db83805

…oses pnp#6158

Fixes syntax highlighting

2c0cb7a

Updates release notes

55df91e

Replaces csv parser. Closes pnp#5825

e212386

Adds new contributor

ff5cef7

Replaces deprecated methods. Closes pnp#6244

5b3a3c1

Adds copilot alias to chatbot commands. Closes pnp#6261

d4fadc1

Adds command 'spp model remove'. Closes pnp#6118

c6a5de6

Allows case-insensitive column names in 'spo listitem batch remove'. C…

8c29adc

…loses pnp#6419

Enhances 'spo site admin' commands to retrieve site ID as admin. Closes

ff9ac4e

pnp#6443

Fixes XML character escaping in 'spo listitem batch set'. Closes pnp#…

5b471f3

…6430

Updates all sample scripts to align with v10. Closes pnp#6369

0a51b5f

Updates release notes

cd9d42a

Merge branch 'issue-6083' of https://github.com/nanddeepn/cli-microso…

4082580

…ft365 into issue-6083

review comments

b39133d

nanddeepn marked this pull request as ready for review November 25, 2024 17:41

Adam-it approved these changes Nov 25, 2024

View reviewed changes

Adam-it marked this pull request as draft November 26, 2024 04:26

Adam-it removed their assignment Nov 26, 2024

nanddeepn closed this Nov 28, 2024

milanholemans mentioned this pull request Nov 28, 2024

Adds 'spe container get' command. Closes #6083 #6507

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds 'spe container get' command. Closes #6083 #6421

Adds 'spe container get' command. Closes #6083 #6421

nanddeepn commented Oct 9, 2024

milanholemans commented Oct 9, 2024

milanholemans commented Oct 9, 2024

Adam-it commented Oct 29, 2024

Adam-it left a comment

Adam-it Nov 20, 2024

Adam-it left a comment

Adam-it commented Nov 25, 2024

Adam-it commented Nov 26, 2024 •

edited

Loading

Adam-it commented Nov 26, 2024

nanddeepn commented Nov 28, 2024

Adam-it commented Nov 28, 2024

nanddeepn commented Nov 28, 2024

Adam-it commented Nov 28, 2024

Adds 'spe container get' command. Closes #6083 #6421

Adds 'spe container get' command. Closes #6083 #6421

Conversation

nanddeepn commented Oct 9, 2024

milanholemans commented Oct 9, 2024

milanholemans commented Oct 9, 2024

Adam-it commented Oct 29, 2024

Adam-it left a comment

Choose a reason for hiding this comment

Adam-it Nov 20, 2024

Choose a reason for hiding this comment

Adam-it left a comment

Choose a reason for hiding this comment

Adam-it commented Nov 25, 2024

Adam-it commented Nov 26, 2024 • edited Loading

Adam-it commented Nov 26, 2024

nanddeepn commented Nov 28, 2024

Adam-it commented Nov 28, 2024

nanddeepn commented Nov 28, 2024

Adam-it commented Nov 28, 2024

Adam-it commented Nov 26, 2024 •

edited

Loading