-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove obsolete example due to changes in user roles in #5558 #6413
remove obsolete example due to changes in user roles in #5558 #6413
Conversation
…oval of deprecated `Guest` value)
Thank you, well try to review it ASAP! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmaestrini Awesome work 👏 You Rock 🤩
Ready to merge 🚀 |
Merged manually. Thank you for your awesome contribution 👏. |
@Adam-it How are you? Wasn't this small contribution here accepted by the hacktoberfest challenge? 😃 |
Did they change the rules? In the past years, just an overall approving review was sufficient. We can apply the |
@tmaestrini I have no idea why it did not work in this case. From the Hacktoberfest event we did everything according to rules our repo is marked with hacktoberfest label and we did approve your PR. so this should be enough. |
No worries, @milanholemans and @Adam-it - was just wondering why this didn't resolve. It doesn't matter - cool that the PR was accepted! 🙌 |
In #5558, the removal of the
Guest
value from the user'srole
was introduced. Issue #6272 should remove the obsolete example.Closes #6272.