Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete example due to changes in user roles in #5558 #6413

Closed

Conversation

tmaestrini
Copy link

@tmaestrini tmaestrini commented Oct 6, 2024

In #5558, the removal of the Guest value from the user's role was introduced. Issue #6272 should remove the obsolete example.

Closes #6272.

@milanholemans
Copy link
Contributor

Thank you, well try to review it ASAP!

@milanholemans milanholemans added docs pr-major PR for the next major release labels Oct 6, 2024
@Adam-it Adam-it self-assigned this Oct 11, 2024
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmaestrini Awesome work 👏 You Rock 🤩

@Adam-it
Copy link
Member

Adam-it commented Oct 11, 2024

Ready to merge 🚀

@Adam-it
Copy link
Member

Adam-it commented Oct 13, 2024

Merged manually. Thank you for your awesome contribution 👏.
You Rock 🤩

@tmaestrini
Copy link
Author

@Adam-it How are you? Wasn't this small contribution here accepted by the hacktoberfest challenge? 😃
image

@milanholemans
Copy link
Contributor

If your PR/MR is being accepted for Hacktoberfest via an overall approving review it must also not be closed.

Did they change the rules? In the past years, just an overall approving review was sufficient. We can apply the hacktoberfest-accepted label, but I'm not sure if it will still count. Sorry for this @tmaestrini.

@milanholemans milanholemans added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Nov 5, 2024
@Adam-it
Copy link
Member

Adam-it commented Nov 5, 2024

@tmaestrini I have no idea why it did not work in this case. From the Hacktoberfest event we did everything according to rules
image

our repo is marked with hacktoberfest label and we did approve your PR. so this should be enough.
Maybe we should contact the hacktoberfest organizers in this case 🤔?

@tmaestrini
Copy link
Author

No worries, @milanholemans and @Adam-it - was just wondering why this didn't resolve. It doesn't matter - cool that the PR was accepted! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-major PR for the next major release pr-merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove obsolete example
3 participants