Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds "m365 spe container list" command. Closes #6082 #6412

Closed
wants to merge 8 commits into from
Closed

Adds "m365 spe container list" command. Closes #6082 #6412

wants to merge 8 commits into from

Conversation

nanddeepn
Copy link
Contributor

Adds m365 spe container list command. Closes #6082

@milanholemans
Copy link
Contributor

Thank you, well try to review it ASAP!

@Adam-it Adam-it self-assigned this Oct 21, 2024
@Adam-it Adam-it mentioned this pull request Oct 24, 2024
Closed
Adam-it
Adam-it requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanddeepn Awesome work so far 👏👏👏👏
I added only a few minor comments we should sort out and we will be ready to merge 🚀
You Rock 🤩

src/utils/spo.ts Outdated
const response: ClientSvcResponseContents = json[0];

if (response.ErrorInfo) {
throw response.ErrorInfo.ErrorMessage;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from util we should rather wrap it with Error

Suggested change
throw response.ErrorInfo.ErrorMessage;
throw new Error(response.ErrorInfo.ErrorMessage);

src/m365/spe/commands/containertype/containertype-list.spec.ts Outdated Show resolved Hide resolved
src/m365/spe/commands/container/container-list.ts Outdated Show resolved Hide resolved
src/m365/spe/commands/container/container-list.ts Outdated Show resolved Hide resolved
@Adam-it Adam-it marked this pull request as draft October 24, 2024 14:12
@nanddeepn nanddeepn marked this pull request as ready for review October 24, 2024 18:00
@Adam-it Adam-it added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 29, 2024

@nanddeepn I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩

Adam-it
Adam-it approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanddeepn Awesome work 👏👏👏👏
I played with it a bit and it works really good
image

@Adam-it
Copy link
Member

Adam-it commented Nov 5, 2024

ready to merge 🚀

@Adam-it
Copy link
Member

Adam-it commented Nov 5, 2024

Merged manually. Awesome work 👏. You Rock 🤩

@Adam-it Adam-it closed this Nov 5, 2024
@nanddeepn nanddeepn deleted the issue-6082 branch November 6, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-it Adam-it Adam-it approved these changes

Assignees

@Adam-it Adam-it

Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command: m365 spe container list
3 participants
@nanddeepn @milanholemans @Adam-it