Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the docs on how to log in to CLI. Closes #6343 #6402

Closed
wants to merge 2 commits into from

Conversation

Jwaegebaert
Copy link
Contributor

Closes #6343

I would suggest to surely double-check how I updated the m365 login docs, not sure if this is a good way to explain it.

@Jwaegebaert Jwaegebaert added the pr-priority Process this PR asap label Oct 2, 2024
Copy link
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Let's do a couple of changes

docs/docs/user-guide/connecting-microsoft-365.mdx Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/docs/cmd/login.mdx Show resolved Hide resolved
docs/docs/cmd/login.mdx Show resolved Hide resolved
docs/docs/concepts/authorization-tokens.mdx Outdated Show resolved Hide resolved
docs/docs/concepts/authorization-tokens.mdx Outdated Show resolved Hide resolved
docs/docs/concepts/authorization-tokens.mdx Outdated Show resolved Hide resolved
docs/docs/user-guide/connecting-microsoft-365.mdx Outdated Show resolved Hide resolved
docs/docs/user-guide/using-own-identity.mdx Outdated Show resolved Hide resolved
@waldekmastykarz waldekmastykarz self-assigned this Oct 3, 2024
Copy link
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's ship it!

@Adam-it Adam-it added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 29, 2024

@Jwaegebaert I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩

@Adam-it Adam-it self-assigned this Nov 14, 2024
@Adam-it
Copy link
Member

Adam-it commented Nov 14, 2024

@waldekmastykarz I will be doing some merges today or tomorrow, so I will take this one as well since this is ready

@Adam-it
Copy link
Member

Adam-it commented Nov 14, 2024

Ready to merge 🚀

@Adam-it
Copy link
Member

Adam-it commented Nov 15, 2024

Merged manually. Thank you for your awesome work! You Rock !🤩

@Adam-it Adam-it closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged pr-priority Process this PR asap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update guide how to log in to CLI
4 participants