Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Alias for spo site list #6377

Closed
wants to merge 1 commit into from
Closed

Adding Alias for spo site list #6377

wants to merge 1 commit into from

Conversation

ktskumar
Copy link
Contributor

@ktskumar ktskumar commented Sep 22, 2024 •
edited by milanholemans
Loading

Added a new command spo tenant site list
Alias command spo site list

Closes #6143

@ktskumar ktskumar mentioned this pull request Sep 22, 2024
Closed
2 tasks
@milanholemans
Copy link
Contributor

Thank you, we'll try to review it ASAP

@MathijsVerbeeck MathijsVerbeeck self-assigned this Oct 4, 2024
@MathijsVerbeeck
Copy link
Contributor

Hi @ktskumar . It seems that we currently have some merge conflicts. Could you resolve these before I can start reviewing?

@MathijsVerbeeck MathijsVerbeeck marked this pull request as draft October 4, 2024 09:09
@ktskumar
Copy link
Contributor Author

ktskumar commented Oct 6, 2024

Hi @ktskumar . It seems that we currently have some merge conflicts. Could you resolve these before I can start reviewing?

Sure will check it..

@milanholemans
Copy link
Contributor

Hi @ktskumar . It seems that we currently have some merge conflicts. Could you resolve these before I can start reviewing?

Sure will check it..

For your info: to resolve your merge conflicts, please rebase your branch with the current main branch. Do not merge the main branch into your branch. Otherwise, we'll have quite some trouble getting it into our code base.

@ktskumar ktskumar closed this Oct 8, 2024
@ktskumar
Copy link
Contributor Author

ktskumar commented Oct 8, 2024 •
edited
Loading

Hi @milanholemans, I have done something wrong. Need some hand to resolve this.

@milanholemans
Copy link
Contributor

Do you need some help? Or will you try to fix it?

@ktskumar
Copy link
Contributor Author

ktskumar commented Oct 8, 2024

Do you need some help? Or will you try to fix it?

Yes. I will try to fix it. Please share, if you have any steps.

@ktskumar ktskumar reopened this Oct 8, 2024
@ktskumar ktskumar marked this pull request as ready for review October 9, 2024 04:41
MathijsVerbeeck
MathijsVerbeeck approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@MathijsVerbeeck MathijsVerbeeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ktskumar. Nice job. I only saw that you forgot to remove the original doc file from spo site list. I will do this myself. Don't worry about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathijsVerbeeck MathijsVerbeeck MathijsVerbeeck approved these changes

Assignees

@MathijsVerbeeck MathijsVerbeeck

Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add alias for spo site list
3 participants
@ktskumar @milanholemans @MathijsVerbeeck