-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds command viva engage community user list
#6371
Conversation
7df47c7
to
89ce714
Compare
89ce714
to
4504b4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jasey,
Command works great. Something that I've noticed is that if we for example have a user that is both a "Admin" and a "Member", we will see the record appear twice in the output, once with the property "roles": ["Member"] and once with roles: ["Admin"]. Is this something that we perhaps could finetune?
src/m365/viva/commands/engage/engage-community-user-list.spec.ts
Outdated
Show resolved
Hide resolved
src/m365/viva/commands/engage/engage-community-user-list.spec.ts
Outdated
Show resolved
Hide resolved
I don’t think this behavior is too bad. It seems logical for users to appear twice if they have two different roles. I’m not sure how we handle this with other commands, but I think it’s okay to keep this behavior. |
All good, just wanted your opinion. Thanks for the clarification. |
Thanks for the PR Jasey. In the future, could you please make sure that your commit message contains the link to the correct issue? :-) |
Closes #6295
In this PR, I've added a new custom method to ourDropping in favor of #6373zod
setup. This method allows us to define 'enums,' or a list of options for a specific command, whichzod
will verify in a case-insensitive manner.