Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds command viva engage community user list #6371

Closed
wants to merge 2 commits into from

Conversation

Jwaegebaert
Copy link
Contributor

@Jwaegebaert Jwaegebaert commented Sep 20, 2024

Closes #6295

In this PR, I've added a new custom method to our zod setup. This method allows us to define 'enums,' or a list of options for a specific command, which zod will verify in a case-insensitive manner. Dropping in favor of #6373

@Jwaegebaert Jwaegebaert added the pr-major PR for the next major release label Sep 27, 2024
@MathijsVerbeeck MathijsVerbeeck self-assigned this Oct 4, 2024
Copy link
Contributor

@MathijsVerbeeck MathijsVerbeeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jasey,

Command works great. Something that I've noticed is that if we for example have a user that is both a "Admin" and a "Member", we will see the record appear twice in the output, once with the property "roles": ["Member"] and once with roles: ["Admin"]. Is this something that we perhaps could finetune?

@MathijsVerbeeck MathijsVerbeeck marked this pull request as draft October 4, 2024 11:04
@Jwaegebaert
Copy link
Contributor Author

Something that I've noticed is that if we for example have a user that is both a "Admin" and a "Member", we will see the record appear twice in the output, once with the property "roles": ["Member"] and once with roles: ["Admin"]. Is this something that we perhaps could finetune?

I don’t think this behavior is too bad. It seems logical for users to appear twice if they have two different roles. I’m not sure how we handle this with other commands, but I think it’s okay to keep this behavior.

@MathijsVerbeeck
Copy link
Contributor

Something that I've noticed is that if we for example have a user that is both a "Admin" and a "Member", we will see the record appear twice in the output, once with the property "roles": ["Member"] and once with roles: ["Admin"]. Is this something that we perhaps could finetune?

I don’t think this behavior is too bad. It seems logical for users to appear twice if they have two different roles. I’m not sure how we handle this with other commands, but I think it’s okay to keep this behavior.

All good, just wanted your opinion. Thanks for the clarification.

@MathijsVerbeeck
Copy link
Contributor

Thanks for the PR Jasey. In the future, could you please make sure that your commit message contains the link to the correct issue? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-major PR for the next major release pr-merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: viva engage community user list
2 participants