Adds a new command spp model list Closes #6103
#6172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @mkm17! We'll review it anytime soon! |
mkm17
force-pushed
the
issues/6103_spp_model_list
branch
from
5c3c9e1
to
64cbd9b
Compare
mkm17
force-pushed
the
issues/6103_spp_model_list
branch
from
64cbd9b
to
baeced2
Compare
milanholemans
requested changes
Sep 7, 2024
There was a problem hiding this comment.
Nice start @mkm17, let's change a few things before we continue.
mkm17
force-pushed
the
issues/6103_spp_model_list
branch
from
baeced2
to
378d487
Compare
milanholemans
requested changes
Sep 19, 2024
There was a problem hiding this comment.
I've noticed a few more things we should change @mkm17, after this it should be good to go.
mkm17
force-pushed
the
issues/6103_spp_model_list
branch
from
378d487
to
1630898
Compare
milanholemans
requested changes
Oct 4, 2024
mkm17
force-pushed
the
issues/6103_spp_model_list
branch
from
1630898
to
17e650d
Compare
milanholemans
approved these changes
Oct 10, 2024
| }); | ||
|
|
||
| await spp.assertSiteIsContentCenter(siteUrl); | ||
| await assert(stubGet.calledOnce); |
There was a problem hiding this comment.
Suggested change
| await assert(stubGet.calledOnce); | |
| assert(stubGet.calledOnce); |
| /** | ||
| * Asserts whether the specified site is a content center | ||
| * @param siteUrl The URL of the site to check | ||
| */ |
There was a problem hiding this comment.
Let's add @throws error when site is not a content center.
|
@milanholemans ok, thank you for all help. I will add also these suggestions to other spp commands |
|
Merged manually, thanks for the new command! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new command
spp model listCloses #6103