Updated based in review comments

pnp · Oct 19, 2024 · 2d51726 · 2d51726
1 parent 42b125f
commit 2d51726
Show file tree

Hide file tree

Showing 10 changed files with 39 additions and 7 deletions.
diff --git a/docs/docs/cmd/pp/copilot/copilot-get.mdx b/docs/docs/cmd/pp/copilot/copilot-get.mdx
@@ -12,7 +12,7 @@ Get information about the specified copilot
 m365 pp copilot get [options]
 ```
 
-## alias
+## Alias
 
 ```sh
 m365 pp chatbot get [options]

diff --git a/docs/docs/cmd/pp/copilot/copilot-list.mdx b/docs/docs/cmd/pp/copilot/copilot-list.mdx
@@ -12,7 +12,7 @@ Lists Microsoft Power Platform copilots in the specified Power Platform environm
 m365 pp copilot list [options]
 ```
 
-## alias
+## Alias
 
 ```sh
 m365 pp chatbot list [options]
@@ -83,9 +83,9 @@ m365 pp copilot list --environmentName "Default-d87a7535-dd31-4437-bfe1-95340acd
   <TabItem value="Text">
 
   ```text
-  name   botid                                 publishedOn           createdOn             botModifiedOn
-  ------------  ------------------------------------  --------------------  --------------------  --------------------
-  CLI Copilot   23f5f586-97fd-43d5-95eb-451c9797a53d  2022-11-19T19:19:53Z  2022-11-19T10:42:22Z  2022-11-19T20:19:57Z
+   name         botid                                  publishedOn            createdOn              botModifiedOn
+  -----------   ------------------------------------   --------------------   --------------------   --------------------
+  CLI Copilot   23f5f586-97fd-43d5-95eb-451c9797a53d   2022-11-19T19:19:53Z   2022-11-19T10:42:22Z   2022-11-19T20:19:57Z
   ```
 
   </TabItem>

diff --git a/docs/docs/cmd/pp/copilot/copilot-remove.mdx b/docs/docs/cmd/pp/copilot/copilot-remove.mdx
@@ -10,7 +10,7 @@ Removes the specified copilot
 m365 pp copilot remove [options]
 ```
 
-## alias
+## Alias
 
 ```sh
 m365 pp chatbot remove [options]

diff --git a/docs/docusaurus.config.ts b/docs/docusaurus.config.ts
@@ -49,6 +49,9 @@ const config: Config = {
       'client-redirects',
       {
         createRedirects(routePath) {
+          if (routePath.includes('/copilot')) {
+            return [routePath.replace('/copilot', '/chatbot')];
+          }
           if (routePath.includes('/entra')) {
             return [routePath.replace('/entra', '/aad')];
           }

diff --git a/src/m365/pp/commands/copilot/copilot-get.spec.ts b/src/m365/pp/commands/copilot/copilot-get.spec.ts
@@ -137,6 +137,16 @@ describe(commands.COPILOT_GET, () => {
     assert.notStrictEqual(command.description, null);
   });
 
+  it('defines alias', () => {
+    const alias = command.alias();
+    assert.notStrictEqual(typeof alias, 'undefined');
+  });
+
+  it('defines correct alias', () => {
+    const alias = command.alias();
+    assert.deepStrictEqual(alias, [commands.COPILOT_GET]);
+  });
+
   it('defines correct properties for the default output', () => {
     assert.deepStrictEqual(command.defaultProperties(), ['name', 'botid', 'publishedon', 'createdon', 'modifiedon']);
   });

diff --git a/src/m365/pp/commands/copilot/copilot-get.ts b/src/m365/pp/commands/copilot/copilot-get.ts
@@ -92,6 +92,7 @@ class PpCopilotGetCommand extends PowerPlatformCommand {
   }
 
   public async commandAction(logger: Logger, args: CommandArgs): Promise<void> {
+    await this.showDeprecationWarning(logger, "pp chatbot get", "pp copilot get");
     if (this.verbose) {
       await logger.logToStderr(`Retrieving copilot '${args.options.id || args.options.name}'...`);
     }

diff --git a/src/m365/pp/commands/copilot/copilot-list.spec.ts b/src/m365/pp/commands/copilot/copilot-list.spec.ts
@@ -185,6 +185,12 @@ describe(commands.COPILOT_LIST, () => {
 
   it('defines alias', () => {
     const alias = command.alias();
-    assert.notStrictEqual(typeof alias, 'undefined');
+    assert.notStrictEqual(typeof alias, 'copilot');
   });
+
+  it('defines correct alias', () => {
+    const alias = command.alias();
+    assert.deepStrictEqual(alias, [commands.COPILOT_LIST]);
+  });
+
 });
diff --git a/src/m365/pp/commands/copilot/copilot-list.ts b/src/m365/pp/commands/copilot/copilot-list.ts
@@ -58,6 +58,7 @@ class PpCopilotListCommand extends PowerPlatformCommand {
   }
 
   public async commandAction(logger: Logger, args: CommandArgs): Promise<void> {
+    await this.showDeprecationWarning(logger, "pp chatbot list", "pp copilot list");
     if (this.verbose) {
       await logger.logToStderr(`Retrieving list of copilots for environment '${args.options.environmentName}'.`);
     }

diff --git a/src/m365/pp/commands/copilot/copilot-remove.spec.ts b/src/m365/pp/commands/copilot/copilot-remove.spec.ts
@@ -84,6 +84,16 @@ describe(commands.COPILOT_REMOVE, () => {
     assert.notStrictEqual(command.description, null);
   });
 
+  it('defines alias', () => {
+    const alias = command.alias();
+    assert.notStrictEqual(typeof alias, 'undefined');
+  });
+
+  it('defines correct alias', () => {
+    const alias = command.alias();
+    assert.deepStrictEqual(alias, [commands.COPILOT_REMOVE]);
+  });
+
   it('fails validation if id is not a valid guid.', async () => {
     const actual = await command.validate({
       options: {

diff --git a/src/m365/pp/commands/copilot/copilot-remove.ts b/src/m365/pp/commands/copilot/copilot-remove.ts
@@ -94,6 +94,7 @@ class PpCopilotRemoveCommand extends PowerPlatformCommand {
   }
 
   public async commandAction(logger: Logger, args: CommandArgs): Promise<void> {
+    await this.showDeprecationWarning(logger, "pp chatbot remove", "pp copilot remove");
     if (this.verbose) {
       await logger.logToStderr(`Removing copilot '${args.options.id || args.options.name}'...`);
     }