fix: should update dependents with the value of the unwrapped atom when the promise resolves #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dmaskasky
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/9E4362EZ4 |
See documentations for usage instructions.
commit: |
Closed
1 task
|
This is such a fundamental thing... I'll take it over. I'll push some commits to #2920. |
dai-shi
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
Fix #2914
Summary
Caused by 34b4f8e and e777f46
It's caused by a subtle timing issue. The promise is resolved before the derived atom is mounted because the mount process runs after the promise is resolved.
There might be a better fix, but for now in this PR, it triggers updates again if it finds atom value change after the mount process. More refactors for store.ts are coming and we may revisit this in the future.
Check List
pnpm run fix:formatfor formatting code and docs