Make looking for parent not crash #2250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have trouble with this [codesandbox](https://codesandbox.io/p/sandbox/scene-transitions-reveal-forked-nnj7py?file=%2Fpackage.json%3A19%2C8): It uses the latest versions of react and fiber. Every frame it fails to find a parent and logs an error. I suppose this is because [this logic](https://github.com/pmndrs/drei/blob/master/src/core/RenderTexture.tsx#L60-L66) doesn't work anymore. I'm proposing a safer variant here, but I'm not sure if internals have changed and there's a better way.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@i-am-the-slime is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I have trouble with this codesandbox:
It uses the latest versions of react and fiber. Every frame it fails to find a parent and logs an error. I suppose this is because this logic doesn't work anymore.
What
I'm proposing a safer variant here checking if __r3f exists, but I'm not sure if internals have changed and there's a better way.
Checklist