slab metrics unit test: test_metrics_flush_basic #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomekIdczak97
force-pushed
the
test_metrics_flush_basic
branch
from
db390c5
to
567b9ee
Compare
PatKamin
reviewed
Aug 2, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @TomekIdczak97)
test/storage/slab_pmem/check_slab_pmem.c, line 1120 at r1 (raw file):
#define VAL1 "val1" #define KEY2 "key2" #define VAL2 "val2"
nit:
Add a new line below defines to improve code readability.
TomekIdczak97
force-pushed
the
test_metrics_flush_basic
branch
from
567b9ee
to
57ed3ab
Compare
PatKamin
reviewed
Aug 8, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
TomekIdczak97
force-pushed
the
test_metrics_flush_basic
branch
2 times, most recently
from
4414e1c
to
4bc9bbc
Compare
TomekIdczak97
force-pushed
the
test_metrics_flush_basic
branch
3 times, most recently
from
cd08ab6
to
f8bd66c
Compare
TomekIdczak97
force-pushed
the
test_metrics_flush_basic
branch
from
f8bd66c
to
28df2aa
Compare
TomekIdczak97
force-pushed
the
test_metrics_flush_basic
branch
from
28df2aa
to
e7ae967
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple slab metrics unit test for pmem: test_metrics_flush_basic
Failure - assertion message:
Saved:
After restart:
This change is