Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slab metrics unit test: test_metrics_delete_basic #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TomekIdczak97
Copy link

@TomekIdczak97 TomekIdczak97 commented Jul 17, 2019

Simple slab metrics unit test for pmem: test_metrics_delete_basic

Fail message:

Assertion 'm1_buf == m2_buf' failed: m1_buf == "STATS item_alloc 1", m2_buf == "STATS item_alloc 0"


This change is Reviewable

@michalbiesek
Copy link

item_alloc is one of stats that is only incremented so this inconsistency is expected.
After reset when slabs/items are processed by recreate method item_alloc is incremented only if item was inserted (when it is linked)

We should wait for upstream repository maintainers to decide how to handle this situation.

@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_delete_basic branch 2 times, most recently from be9e255 to 21a5dd0 Compare July 22, 2019 09:35
@TomekIdczak97
Copy link
Author

TomekIdczak97 commented Jul 22, 2019

Failure - assertion message:
Saved:

STATS item_alloc 1
STATS item_dealloc 1
STATS item_link 1
STATS item_unlink 1

After restart:

STATS item_alloc 0
STATS item_dealloc 0
STATS item_link 0
STATS item_unlink 0

@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_delete_basic branch 2 times, most recently from 0e2db64 to 0032f5d Compare August 12, 2019 06:42
@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_delete_basic branch 3 times, most recently from 5db9d0f to d468066 Compare August 20, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants