Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloud cluster autoselection #568

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix cloud cluster autoselection #568

merged 1 commit into from
Oct 18, 2024

Conversation

michaeljguarino
Copy link
Member

This wasn't quite correct in the last iteration. Fixes a few bugs and also fixes some redunant login requests in the command flow

Test Plan

n/a

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino
Fix cloud cluster autoselection
6b3bddd 
This wasn't quite correct in the last iteration. Fixes a few bugs and also fixes some redunant login requests in the command flow
@michaeljguarino michaeljguarino added the enhancement New feature or request label Oct 18, 2024
@michaeljguarino michaeljguarino added hotfix bug-fix This pull request fixes a bug and removed enhancement New feature or request labels Oct 18, 2024
@michaeljguarino michaeljguarino merged commit bda86f3 into main Oct 18, 2024
14 checks passed
@michaeljguarino michaeljguarino deleted the fix-cluster-selector branch October 18, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zreigz zreigz Awaiting requested review from zreigz zreigz is a code owner

@floreks floreks Awaiting requested review from floreks floreks is a code owner

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm maciaszczykm is a code owner

Assignees
No one assigned
Labels
bug-fix This pull request fixes a bug hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaeljguarino