better streamline plural up --cloud #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zreigz
requested review from
michaeljguarino,
floreks and
maciaszczykm
as code owners
cmd/command/up/up.go
Outdated
|
|
||
| func getCluster(cd *cd.Plural) (id string, name string, err error) { | ||
| if cd == nil { | ||
| return "", "", fmt.Errorf("please provide a plural client") |
There was a problem hiding this comment.
probably should change this error message to something like:
You're cli is not logged into Plural, try running `plural login` to generate local credentials.
| @@ -118,19 +118,12 @@ func (p *Plural) cdClusterCommands() []cli.Command { | |||
| } | |||
|
|
|||
| func (p *Plural) handleListClusters(_ *cli.Context) error { | |||
There was a problem hiding this comment.
This actually does work, but we can also use the consoleInstances query, which just selects Plural cloud clusters.
There was a problem hiding this comment.
I searched the whole schema.graphql and couldn't find this query
pkg/provider/aws.go
Outdated
| @@ -159,17 +159,20 @@ func getEC2Client(ctx context.Context, region string) (*ec2.Client, error) { | |||
| } | |||
|
|
|||
| // TODO: during Plural init we should ask the user to choose which AZs they want to use (first 3, random, manual, look at how CAPA does that). There should be a minimum limit of 3. | |||
| func getAvailabilityZones(ctx context.Context, region string) ([]string, error) { | |||
| func getAvailabilityZones(ctx context.Context, region string, cloudFlag bool) ([]string, error) { | |||
There was a problem hiding this comment.
could we just have this default to first3 entirely? It's not piped into plural up at all so is actually irrelevant at the moment. Was only for CAPI if i remember
|
@michaeljguarino PTAL |
michaeljguarino
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
replace the cluster name field with querying all the console instances for a user, using a select to choose the one they want to use, and use that name for the cluster name
no longer ask for the az spread (just chose one as a default and ignore)
make the bucket prefix automatically plrl-cloud-${name}.
Labels
Test Plan
Checklist