Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Breadcrumbs improvements #654

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Oct 8, 2024

It is an attempt to fix two issues from the main app:

  • TypeError: null is not an object (evaluating 'RO.disconnect')
  • Type Error: Array.from requires an array-like object - not null or undefined

Required for pluralsh/plural#1375.

@maciaszczykm maciaszczykm requested a review from a team as a code owner October 8, 2024 12:10
@maciaszczykm maciaszczykm changed the title fixadd null check to resize observer disconnect call fix: add null check to resize observer disconnect call Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Visit the preview URL for this PR (updated for commit 78d930c):

https://pluralsh-design--pr654-resize-observer-null-vw74bjqb.web.app

(expires Tue, 15 Oct 2024 12:20:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 784914c934330f8d0a9fd65c68898b3988262b7d

@maciaszczykm maciaszczykm changed the title fix: add null check to resize observer disconnect call fix: Breadcrumbs improvements Oct 8, 2024
@maciaszczykm maciaszczykm added the bug Something isn't working label Oct 8, 2024
@maciaszczykm maciaszczykm merged commit bcb96a8 into main Oct 8, 2024
14 checks passed
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 3.74.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jsladerman jsladerman deleted the resize-observer-null-check branch October 8, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants