Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accordion default styles #626

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jsladerman
Copy link
Contributor

@jsladerman jsladerman commented Jul 22, 2024

adds a few basic default styles/props to the new accordion which was relatively unstyled by default

removes accordion context hooks (useCloseItem, useIsItemOpen), components that need that functionality should just be controlling the accordion values explicitly

also removes old accordion version

@jsladerman jsladerman added the enhancement New feature or request label Jul 22, 2024
@jsladerman jsladerman requested a review from a team July 22, 2024 23:04
Copy link

linear bot commented Jul 22, 2024

Copy link

github-actions bot commented Jul 22, 2024

Visit the preview URL for this PR (updated for commit 9de5383):

https://pluralsh-design--pr626-jake-prod-2437-accor-ned6klru.web.app

(expires Wed, 31 Jul 2024 02:40:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 784914c934330f8d0a9fd65c68898b3988262b7d

@jsladerman jsladerman force-pushed the jake/prod-2437-accordion-component branch 9 times, most recently from 40470ab to 1caab23 Compare July 23, 2024 21:00
@jsladerman jsladerman force-pushed the jake/prod-2437-accordion-component branch from 1caab23 to 9de5383 Compare July 24, 2024 02:38
@jsladerman jsladerman merged commit 43f4f95 into main Jul 24, 2024
11 checks passed
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 3.58.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jsladerman jsladerman deleted the jake/prod-2437-accordion-component branch July 24, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants