-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add network-observability-operator #957
base: master
Are you sure you want to change the base?
Conversation
Visit the preview URL for this PR (updated for commit 2fd968a): https://pluralsh-console--pr957-network-observabilit-j2ow8vfd.web.app (expires Wed, 22 May 2024 11:12:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce |
min_sharding_lookback: 0s | ||
split_queries_by_interval: 1m | ||
--- | ||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we need to embed loki? Ideally it would ship the logs to a centrally hosted loki somewhere (and we'd just provide url and auth information to the chart to configure that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used it for testing, I will remove it
# - "namespace_drop_packets_total" | ||
# - "namespace_rtt_seconds" | ||
# Kafka consumer stage configuration | ||
kafkaConsumerReplicas: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should configure w/o the kafka buffer by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@michaeljguarino PTAL |
dnsPolicy: ClusterFirst | ||
restartPolicy: Always | ||
schedulerName: default-scheduler | ||
securityContext: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot about this, but we should allow customizability of the security context for both containers and the overall pod
# Change mode to "LokiStack" to use with the loki operator | ||
mode: Monolithic | ||
monolithic: | ||
url: {{ .Values.lokiUrl }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to configure auth as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I have to check possible options
Add network-observability-operator
To set Loki add service secret:
lokiUrl
Test Plan
Checklist