Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPES: Making parsing not reliant on NaN #992

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Conversation

invemichele
Copy link
Contributor

Description

I added a check to avoid relying on std::isnan for parsing.
This resolves issues with intel compiler see #990

Target release

I would like my code to appear in release v2.8

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f8280c) 85.91% compared to head (b4ace0e) 85.91%.

❗ Current head b4ace0e differs from pull request most recent head fae2c45. Consider uploading reports for the commit fae2c45 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             v2.8     #992   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         595      595           
  Lines       49731    49731           
=======================================
  Hits        42724    42724           
  Misses       7007     7007           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlocamilloni carlocamilloni merged commit 31b39e4 into plumed:v2.8 Nov 29, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants