Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag display on entities with parenthesis in their names #158

Merged

Conversation

AdrienClairembault
Copy link
Contributor

Tag are not displayed on entities with parenthesis in their names:

image

There is some weird condition looking for a ), not sure whats its doing since there is no comment in the code but it works as expected once it's removed:

image

Copy link
Contributor

@orthagh orthagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like said in mattermost, old code was because before 10.0, entity was displayed between parenthesis on top of items.
Not the case anymore.

@cedric-anne cedric-anne merged commit e6d637d into pluginsGLPI:main Dec 5, 2023
5 checks passed
@cedric-anne cedric-anne added this to the 2.11.7 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants