phpstan lvl 1; rename method & drop useless param

pluginsGLPI · Oct 30, 2023 · 0f7e3c7 · 0f7e3c7
1 parent 3e2e162
commit 0f7e3c7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/inc/sccm.class.php b/inc/sccm.class.php
@@ -80,7 +80,7 @@ public function getDevices($where = 0, $limit = 99999999)
         $PluginSccmSccmdb->disconnect();
     }
 
-    public function getDatas($type, $deviceid, $limit = 99999999)
+    public function getProcessorsDatas($deviceid, $limit = 99999999)
     {
 
         $PluginSccmSccmdb = new PluginSccmSccmdb();
@@ -91,12 +91,8 @@ public function getDatas($type, $deviceid, $limit = 99999999)
 
         $datas = [];
 
-        switch ($type) {
-            case 'processors':
-                $fields = ['Manufacturer00','Name00','NormSpeed00','AddressWidth00','CPUKey00','NumberOfCores00', 'NumberOfLogicalProcessors00'];
-                $table = 'Processor_DATA';
-                break;
-        }
+        $fields = ['Manufacturer00','Name00','NormSpeed00','AddressWidth00','CPUKey00','NumberOfCores00', 'NumberOfLogicalProcessors00'];
+        $table = 'Processor_DATA';
 
         $query = "SELECT " . implode(',', $fields) . "\n";
         $query .= " FROM " . $table . "\n";

diff --git a/inc/sccmxml.class.php b/inc/sccmxml.class.php
@@ -188,7 +188,8 @@ public function setProcessors()
 
         $CONTENT    = $this->sxml->CONTENT[0];
         $i = 0;
-        foreach ($PluginSccmSccm->getDatas('processors', $this->device_id) as $value) {
+        $cpu_data = $PluginSccmSccm->getProcessorsDatas($this->device_id);
+        foreach ($cpu_data as $value) {
             if (!in_array($value['CPUKey00'], $cpukeys)) {
                 $CONTENT->addChild('CPUS');
                 $CPUS = $this->sxml->CONTENT[0]->CPUS[$i];

diff --git a/phpstan.neon b/phpstan.neon
@@ -1,7 +1,7 @@
 parameters:
     parallel:
         maximumNumberOfProcesses: 2
-    level: 0
+    level: 1
     bootstrapFiles:
         - ../../inc/based_config.php
         - setup.php