fix migration update

[Rom1-B]

ref !31826

Fix error message during plugin update (since #372) :

SQL Error "1062": Duplicate entry '0-PluginOrderOrder-1' for key 'unicity' in query "UPDATE `glpi_displaypreferences` SET `itemtype` = 'PluginOrderOrder' WHERE `itemtype` = '3150'"
In DBmysql.php line 1535:
update itemtype of table glpi_displaypreferences for PluginOrderOrder - Erreur durant l'éxecution de la requête : UPDATE `glpi_displaypreferences` SET `itemtype` = 'PluginOrderOrder' WHERE `itemtype` = '3150' - L'erreur est Duplicate entry '0-PluginOrderOrder-1' for key 'unicity'

[AdrienClairembault]

The changes looks good to me (checking the table seems necessary) but I don't see how it would fix the specific error you mentioned.

If $table doesn't exist, shouldn't we get the Unable to rename table %1$s (%2$s) to %3$s (%4$s)! error instead (which is not the same error that in your description). ?

[stonebuzz]

@AdrienClairembault

below, there is displayPref migration if $domigration_itemtypes = true

 
           //Only migrate itemtypes when it's only necessary, otherwise it breaks upgrade procedure !
            if ($domigration_itemtypes) {
                Plugin::migrateItemType(
                    [3150 => 'PluginOrderOrder'],
                    ["glpi_savedsearches", "glpi_savedsearches_users",
                        "glpi_displaypreferences", "glpi_documents_items",
                        "glpi_infocoms", "glpi_logs", "glpi_tickets"
                    ],
                    []
                );
            }

without the check $DB->tableExists('glpi_plugin_order') the migration of displayPref is constantly executed

[Rom1-B]

When the update renames the table, this block is executed (it was never executed before the previous PR mentioned).

As there is a uniqueness key on users_id, itemtype and num, it raises the error when trying to replace '3150' with 'PluginOrderOrder', as the key with PluginOrderOrder already exists.