phpstan lvl 1 #37
phpstan lvl 1 #37
Conversation
trasher
force-pushed
the
feature/phpstan
branch
2 times, most recently
from
8e30231 to
329c3e2
Compare
trasher
force-pushed
the
feature/phpstan
branch
from
329c3e2 to
222e1dd
Compare
|
No idea why |
| @@ -5,6 +5,7 @@ | |||
| "require-dev": { | |||
| "glpi-project/tools": "^0.6", | |||
| "php-parallel-lint/php-parallel-lint": "^1.3", | |||
| "phpstan/phpstan": "^1.10", | |||
There was a problem hiding this comment.
You should also add phpstan/extension-installer and phpstan/phpstan-deprecation-rules, to be able to trigger errors when a deprecated method is used.
inc/mailcollectorfeature.class.php
Outdated
| @@ -308,10 +308,11 @@ public static function updateMailCollectorOnAuthorizationCallback( | |||
| 'login' => $authorization->fields['email'], | |||
| ] | |||
| ); | |||
| Html::redirect($mailcollector->getLinkURL()); | |||
There was a problem hiding this comment.
We should try to redirect to $mailcollector->getLinkURL() even if $success === false, and if we do not have a valid mailcollector ID (this is not an expected usecase), we should redirect to the mail collector list. Indeed Html::back() will probably redirect user on the last page of the external provider OAuth authorization page, and is may result in a redirection loop.
$mailcollector = new MailCollector();
$mailcollector_id = $params[$mailcollector->getForeignKeyField()] ?? null;
if ($mailcollector_id !== null && $mailcollector->getFromDB($mailcollector_id)) {
if ($success) {
// Store authorized email into MailCollector
$mailcollector->update(
[
'id' => $mailcollector_id,
'login' => $authorization->fields['email'],
]
);
}
Html::redirect($mailcollector->getLinkURL());
}
Html::back($mailcollector->getSearchURL());There was a problem hiding this comment.
I'm pretty sure getLinkURL will not work as expected if getFromDB fails; see 0fd143c
Co-authored-by: Cédric Anne <[email protected]>
Co-authored-by: Cédric Anne <[email protected]>
|
Currently failing with |
The current CI process uses the nightly build of GLPI, and this nightly build does not include the "development" files, like stubs, tests, ... I will try to produce soon a "plugins CI" image that contains a "dev" version of GLPI. It would probably help to speed up CI on all plugins, and simplify the way GLPI is retrieved. |
|
OK, so I'll let this one as draft; and I think I'll stop working on other plugins CI because its going to change. |
No description provided.