Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Entity Based Generation #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

grazzianos
Copy link

Hello @cedric-anne. In this pull, I've modified some points of code to allow Entity Based Inventory generation. Now the plugin is useful to my company and I think with this modifications could be useful to the project and habitual users. If you can evaluate them I'll be thankfull.

@cedric-anne cedric-anne changed the base branch from master to develop March 1, 2021 08:52
@cedric-anne cedric-anne self-requested a review February 2, 2022 16:00
@cedric-anne
Copy link
Contributor

This may be a good idea, but problem is it will change the behaviour for everyone, and many people do not want this.

IMHO, something similar than an entity configuration should be added to be able to control this behaviour. For instance, user may want to inherit indexes from parent entity (the current behaviour), while other may want to use different indexes for each entities (your proposal).

Copy link
Contributor

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment.

@grazzianos
Copy link
Author

grazzianos commented Jun 27, 2022 via email

@cedric-anne
Copy link
Contributor

Hi,

Indeed, if we had an option "Use counters specific to each entity" in the plugin configuration (with a default value to false), it could permit to integrate your feature without changing the existing behaviour on existing installations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants