fix(Impact): use genericobject/front/getimpacticon.php to serve icon

[stonebuzz]

Icon from genericobject is badly display from GLPI impact analysis

See relative path containing a double backslash

Clean relative icon path by removing extra backslash

as is already added by glpi core

https://github.com/glpi-project/glpi/blob/5d510f7cb9cd775a9477f98059a8e7569e2f904c/src/Impact.php#L1029

[stonebuzz]

After applying fix

[cedric-anne]

files directory is not supposed to be exposed. It may be the time to fix it.

[stonebuzz]

the first solution may not work if GLPI's "fiels" folder is in a different location (downstream.php and GLPI_VAR_DIR constant)

using pluginimage.send.php seems more appropriate

But does not allow to specify a subfolder

We have to wait for this PR

glpi-project/glpi#16241

[trasher]

You'll have to set minimal GLPI version to 10.0.12 if glpi-project/glpi#16241 is needed.

[AdrienClairembault]

I can't add an icon to my custom objects:

[2023-12-26 10:20:04] glpiphplog.WARNING:   *** PHP Warning (2): rename(/home/teclib/localhost/glpi/10.0-bugfixes/files/_tmp/60d67067881900.71152486B.png,front/pluginimage.send.php?plugin=genericobject&folder=impact_icons&name=PluginGenericobjectVoiture_60d67067881900.71152486B.png): No such file or directory in /home/teclib/localhost/glpi/10.0-bugfixes/plugins/genericobject/inc/type.class.php at line 289
  Backtrace :
  plugins/genericobject/inc/type.class.php:289       rename()
  plugins/genericobject/inc/type.class.php:218       PluginGenericobjectType->handleImpactIconUpdate()
  src/CommonDBTM.php:1612                            PluginGenericobjectType->prepareInputForUpdate()
  plugins/genericobject/front/type.form.php:51       CommonDBTM->update()

[AdrienClairembault]

Also could you confirm the specific case where the original issue happens ? Icons work fine on my side so I suppose its only with a specific config ?

[stonebuzz]

GLPI 10.0.12-dev
Genericobject -> master branch
GLPI router enabled
downstream.php disabled

Icon added to generic object

Icon displayed from impact analysis tab (from generic object)

Icon displayed from impact analysis tab (from computer object)

computed path :

GLPI 10.0.12-dev
Genericobject -> master branch
GLPI router enabled
downstream.php enabled

Default icon is displayed from impact analysis tab (from generic object)

Default icon is displayed from impact analysis tab (from computer object)

computed path :

I think the problem is with the GLPI router and/or downstream.

I've reworked the PR because the plugin already uses a dedicated front-end (front/getimpacticon.php) to load the image

(it's no longer necessary to use pluginimage.send.php).

[stonebuzz]

It doesn't matter whether the image is displayed in the impact analysis or in the object configuration.

The plugin will always use getImpactIconUrl (dedicated front getimpacticon.php to not exposed files directory).

Only the call from the impact analysis does not have to contain the full path to prevent double backslash )