Fix(Core): Hide items without proper user access rights in the fami…

…ly list. (#392) * Update familylist.php to remove items that user don't have right access instead listing all items of a family, and on click get 'you don't have access' error message, juste remove it from the listing. * Update familylist.php * fix CS * adapt CHANGELOG --------- Co-authored-by: stonebuzz <[email protected]>
pluginsGLPI · Nov 28, 2024 · 53a2dcc · 53a2dcc
1 parent a6fcbb5
commit 53a2dcc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+### Fixed
+
+-  Hide `items` without proper user access rights in the family list.
+
 ## [2.14.10] - 2024-09-06
 
 ### Fixed

diff --git a/front/familylist.php b/front/familylist.php
@@ -57,10 +57,12 @@
     echo "<tr class='tab_bg_2'><th>" . Dropdown::getDropdownName("glpi_plugin_genericobject_typefamilies", $_GET['id']) . "</th></tr>";
     foreach ($types as $type) {
         $itemtype = $type['itemtype'];
-        echo "<tr class='tab_bg_1'><td align='center'>";
-        echo "<a href='" . $itemtype::getSearchURL() . "'>";
-        echo $itemtype::getTypeName();
-        echo "</a></td></tr>";
+        if (Session::haveRight(PluginGenericobjectProfile::getProfileNameForItemtype($itemtype), READ)) {
+            echo "<tr class='tab_bg_1'><td align='center'>";
+            echo "<a href='" . $itemtype::getSearchURL() . "'>";
+            echo $itemtype::getTypeName();
+            echo "</a></td></tr>";
+        }
     }
     echo "</table>";
 }