Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phpcs + phpstan #72

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Phpcs + phpstan #72

merged 4 commits into from
Apr 29, 2024

Conversation

Rom1-B
Copy link
Contributor

@Rom1-B Rom1-B commented Apr 26, 2024

Phpcs + phpstan

@Rom1-B
Copy link
Contributor Author

Rom1-B commented Apr 26, 2024

@cedric-anne,

I guess it fails because "Install dependencies" is run before "Misc lint"?
https://github.com/glpi-project/plugin-ci-workflows/blob/v1/.github/workflows/continuous-integration.yml

@cedric-anne
Copy link
Contributor

Headers will not be checked in the public/lib directory. Maybe you could change the target directory of JS file to public/lib:

gantt/webpack.config.js

Line 42 in ff59d3c

path: path.resolve(__dirname, 'public/build'),

@Rom1-B Rom1-B merged commit e62e9f6 into pluginsGLPI:main Apr 29, 2024
3 checks passed
@Rom1-B Rom1-B deleted the phpcs branch April 29, 2024 07:33
@Rom1-B Rom1-B mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonebuzz stonebuzz Awaiting requested review from stonebuzz

@AdrienClairembault AdrienClairembault Awaiting requested review from AdrienClairembault

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rom1-B @cedric-anne @AdrienClairembault