Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent destroy #868

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Prevent destroy #868

merged 7 commits into from
Dec 13, 2024

Conversation

stonebuzz
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !35567

If two blocks share the same dropdown field, removing it from the first block disrupts the second, as the associated dropdown table/class is deleted while still being referenced elsewhere.

This PR introduces a verification step before deleting a field, ensuring it is not in use by another block, thus preventing data inconsistencies and operational issues.

Screenshots (if appropriate):

@stonebuzz stonebuzz self-assigned this Dec 11, 2024
@stonebuzz stonebuzz added the bug label Dec 11, 2024
@stonebuzz stonebuzz merged commit 53c66e1 into pluginsGLPI:main Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant