Remove user deletion when we add more than one user #269
+99
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rom1-B
requested changes
Dec 18, 2024
| @@ -622,7 +622,6 @@ public static function item_add_user(Ticket_User $item, $type = CommonITILActor: | |||
| $ticket->getFromDB($tickets_id); | |||
| $groups_id = []; | |||
|
|
|||
| self::removeAssignUsers($ticket, $users_id, $type); | |||
There was a problem hiding this comment.
What is the value of $users_id? Does it properly include the two actors in your example?
There was a problem hiding this comment.
No, it takes care of users 1 by 1
There was a problem hiding this comment.
Simply removing the call to removeAssignUsers() might cause regressions elsewhere.
As suggested by @stonebuzz, please perform a git bisect, and tests would be welcome.
There was a problem hiding this comment.
apparently broken behaviour since version 2.9.8
|
Can you do a (from memory that part had been reworked #219) Mayve the related commit is involved |
Lainow
force-pushed
the
fix-user-deletion
branch
7 times, most recently
from
e4c9744 to
08e2fe7
Compare
stonebuzz
requested changes
Dec 19, 2024
Lainow
force-pushed
the
fix-user-deletion
branch
6 times, most recently
from
bd4c694 to
cf55101
Compare
Lainow
force-pushed
the
fix-user-deletion
branch
from
cf55101 to
47eb3db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
When we try to add several technicians to a ticket with the escalation plugin enabled and the Remove technician(s) on escalation option active, only 1 is assigned.
Screenshots (if appropriate):