Set params types and remove useless phpstan ignore

pluginsGLPI · Jun 7, 2024 · 23bad0b · 23bad0b
1 parent 4a9faef
commit 23bad0b
Show file tree

Hide file tree

Showing 59 changed files with 326 additions and 355 deletions.
diff --git a/front/info.form.php b/front/info.form.php
@@ -44,6 +44,5 @@
     }
     Html::back();
 }
-/** @phpstan-ignore-next-line */
 Session::setActiveTab('PluginDatainjectionModel', 'PluginDatainjectionModel$5');
 Html::back();
diff --git a/front/mapping.form.php b/front/mapping.form.php
@@ -72,7 +72,6 @@
                 $_POST['models_id'],
                 PluginDatainjectionModel::OTHERS_STEP
             );
-            /** @phpstan-ignore-next-line */
             Session::setActiveTab('PluginDatainjectionModel', 'PluginDatainjectionModel$5');
             Session::addMessageAfterRedirect(
                 __(

diff --git a/front/model.form.php b/front/model.form.php
@@ -47,7 +47,6 @@
     $newID = $model->add($_POST);
 
     //Set display to the advanced options tab
-    /** @phpstan-ignore-next-line */
     Session::setActiveTab('PluginDatainjectionModel', 'PluginDatainjectionModel$3');
     Html::redirect(Toolbox::getItemTypeFormURL('PluginDatainjectionModel') . "?id=$newID");
 } else if (isset($_POST["delete"])) {
@@ -81,7 +80,6 @@
                 ]
             )
         ) {
-            /** @phpstan-ignore-next-line */
             Session::setActiveTab('PluginDatainjectionModel', 'PluginDatainjectionModel$4');
         } else {
             Session::addMessageAfterRedirect(

diff --git a/hook.php b/hook.php
@@ -1921,8 +1921,8 @@ function plugin_datainjection_update220_230()
 
 
 /**
- * @param $hook_name
- * @param $params       array
+ * @param string $hook_name
+ * @param array $params
 **/
 function plugin_datainjection_loadHook($hook_name, $params = [])
 {
@@ -1968,7 +1968,7 @@ function plugin_datainjection_needUpdateOrInstall()
 /**
  * Used for filter list of models
  *
- * @param $itemtype
+ * @param string $itemtype
 **/
 function plugin_datainjection_addDefaultWhere($itemtype)
 {

diff --git a/inc/autoupdatesysteminjection.class.php b/inc/autoupdatesysteminjection.class.php
@@ -75,8 +75,8 @@ public function getOptions($primary_type = '')
     /**
     * Standard method to add an object into glpi
     *
-    * @param $values  array fields to add into glpi
-    * @param $options array options used during creation
+    * @param array $values  array fields to add into glpi
+    * @param array $options array options used during creation
     *
     * @return array of IDs of newly created objects : for example array(Computer=>1, Networkport=>10)
    **/

diff --git a/inc/backend.class.php b/inc/backend.class.php
@@ -47,12 +47,12 @@ abstract class PluginDatainjectionBackend
     /**
     * Get header of the file
     *
-    * @param $injectionData
-    * @param $header_present
+    * @param PluginDatainjectionData|null $injectionData
+    * @param boolean $header_present
     *
     * @return array with the data from the header
    **/
-    public static function getHeader(PluginDatainjectionData $injectionData, $header_present)
+    public static function getHeader($injectionData, $header_present)
     {
 
         if ($header_present) {
@@ -71,7 +71,7 @@ public static function getHeader(PluginDatainjectionData $injectionData, $header
     /**
     * Get the backend implementation by type
     *
-    * @param $type
+    * @param string $type
    **/
     public static function getInstance($type)
     {

diff --git a/inc/backendcsv.class.php b/inc/backendcsv.class.php
@@ -57,7 +57,7 @@ public function isHeaderPresent()
 
 
     /**
-    * @param $delimiter
+    * @param string $delimiter
    **/
     public function setDelimiter($delimiter)
     {
@@ -67,7 +67,7 @@ public function setDelimiter($delimiter)
 
 
     /**
-    * @param $present (true by default)
+    * @param boolean $present (true by default)
    **/
     public function setHeaderPresent($present = true)
     {
@@ -79,9 +79,9 @@ public function setHeaderPresent($present = true)
     /**
     * CSV File parsing methods
     *
-    * @param $fic
-    * @param $data
-    * @param $encoding  (default 1)
+    * @param mixed $fic
+    * @param mixed $data
+    * @param integer $encoding  (default 1)
    **/
     public static function parseLine($fic, $data, $encoding = 1)
     {
@@ -124,8 +124,8 @@ public static function parseLine($fic, $data, $encoding = 1)
 
 
     /**
-    * @param $newfile
-    * @param $encoding
+    * @param string $newfile
+    * @param string $encoding
    **/
     public function init($newfile, $encoding)
     {
@@ -138,7 +138,7 @@ public function init($newfile, $encoding)
     /**
     * Read a CSV file and store data in an array
     *
-    * @param $numberOfLines inumber of lines to be read (-1 means all file) (default 1)
+    * @param integer $numberOfLines inumber of lines to be read (-1 means all file) (default 1)
    **/
     public function read($numberOfLines = 1)
     {

diff --git a/inc/backendinterface.class.php b/inc/backendinterface.class.php
@@ -36,7 +36,7 @@ interface PluginDatainjectionBackendInterface
     /**
     * Read from file
     *
-    * @param $numberOfLines (default 1)
+    * @param integer $numberOfLines (default 1)
    **/
     public function read($numberOfLines = 1);
 

diff --git a/inc/clientinjection.class.php b/inc/clientinjection.class.php
@@ -39,13 +39,6 @@ class PluginDatainjectionClientInjection
     //Injection results
     private $results = [];
 
-    //Model used for injection
-    private $model; /** @phpstan-ignore-line */
-
-    //Overall injection results
-    private $global_results; /** @phpstan-ignore-line */
-
-
     /**
     * Print a good title for group pages
     *
@@ -140,7 +133,7 @@ public function showForm($ID, $options = [])
 
 
     /**
-    * @param $options   array
+    * @param array $options
    **/
     public static function showUploadFileForm($options = [])
     {
@@ -197,8 +190,8 @@ public static function showUploadFileForm($options = [])
 
 
     /**
-    * @param $model        PluginDatainjectionModel object
-    * @param $entities_id
+    * @param PluginDatainjectionModel $model PluginDatainjectionModel object
+    * @param integer $entities_id
    **/
     public static function showInjectionForm(PluginDatainjectionModel $model, $entities_id)
     {
@@ -228,8 +221,8 @@ public static function showInjectionForm(PluginDatainjectionModel $model, $entit
 
 
     /**
-    * @param $model        PluginDatainjectionModel object
-    * @param $entities_id
+    * @param PluginDatainjectionModel $model
+    * @param integer $entities_id
    **/
     public static function processInjection(PluginDatainjectionModel $model, $entities_id)
     {
@@ -340,7 +333,7 @@ public static function processInjection(PluginDatainjectionModel $model, $entiti
     * to be used instead of Toolbox::stripslashes_deep to reduce memory usage
     * execute stripslashes in place (no copy)
     *
-    * @param $value array of value
+    * @param array|null $value array of value
     */
     public static function stripslashes_array(&$value) // phpcs:ignore
     {
@@ -356,7 +349,7 @@ public static function stripslashes_array(&$value) // phpcs:ignore
 
 
     /**
-    * @param $model  PluginDatainjectionModel object
+    * @param PluginDatainjectionModel $model  PluginDatainjectionModel object
    **/
     public static function showResultsForm(PluginDatainjectionModel $model)
     {