Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ci #9

Merged
merged 9 commits into from
Nov 14, 2023
Merged

Feature/ci #9

merged 9 commits into from
Nov 14, 2023

Conversation

trasher
Copy link
Contributor

@trasher trasher commented Nov 3, 2023

No description provided.

cedric-anne
cedric-anne reviewed Nov 6, 2023
View reviewed changes
phpstan.neon Outdated Show resolved Hide resolved
@trasher
Copy link
Contributor Author

trasher commented Nov 6, 2023

To switch to level 2, remaining errors are all similar to:

  Line   inc/computergroupdynamic.class.php                
  57     Call to an undefined method CommonGLPI::getID().

Indeed, getID does exists only in CommonDBTM, and method signature expect a CommonGLPI. I'm not sure how to "fix" that (phpstan line exclusion on all occurrences does not seems the best idea).

@cedric-anne
Copy link
Contributor

inc/computergroupdynamic.class.php

Maybe replace get_class($item) == PluginDatabaseinventoryComputerGroup::getType() by $item instanceof PluginDatabaseinventoryComputerGroup.

@trasher trasher marked this pull request as ready for review November 7, 2023 09:36
@trasher
Copy link
Contributor Author

trasher commented Nov 7, 2023

Remaining issues are caused from a core phpdoc error

@trasher
Copy link
Contributor Author

trasher commented Nov 7, 2023

Fixed by glpi-project/glpi#15953

@trasher trasher merged commit 47fc06f into main Nov 14, 2023
5 checks passed
@trasher trasher deleted the feature/ci branch November 14, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-anne cedric-anne cedric-anne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trasher @cedric-anne