Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Pass all page in Twig #7

Merged
merged 10 commits into from
Feb 21, 2024
Merged

Feature: Pass all page in Twig #7

merged 10 commits into from
Feb 21, 2024

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Sep 26, 2023

Update of the databaseinventory plugin to switch all html pages to twig.

@Lainow Lainow changed the title Twigupdatev2 feature: pass html page in twig Sep 26, 2023
@Lainow Lainow changed the title feature: pass html page in twig Feature: Pass all page in Twig Oct 25, 2023
stonebuzz
stonebuzz requested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems ok for me =)

can you jsut change icon for this (with a computer)

image

@trasher
Copy link
Contributor

trasher commented Dec 5, 2023

ping?

@cedric-anne cedric-anne requested review from stonebuzz, Rom1-B and AdrienClairembault and removed request for cedric-anne February 21, 2024 08:04
@stonebuzz stonebuzz added the enhancement New feature or request label Feb 21, 2024
@stonebuzz stonebuzz added this to the 1.0.1 milestone Feb 21, 2024
AdrienClairembault
AdrienClairembault approved these changes Feb 21, 2024
View reviewed changes
Copy link

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good but a bit hard to read everything.

I think doing one template per PR would be easier to review in the future.

@stonebuzz stonebuzz merged commit 5d760d4 into pluginsGLPI:main Feb 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

@stonebuzz stonebuzz stonebuzz approved these changes

@Rom1-B Rom1-B Awaiting requested review from Rom1-B

Assignees

@Lainow Lainow

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Lainow @trasher @stonebuzz @AdrienClairembault