Feature/refferal contract #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsam4
reviewed
Oct 27, 2020
contracts/Referral.sol
Outdated
| */ | ||
| modifier onlyOwner() { | ||
| require(owner == msg.sender, "Not owner"); | ||
| _; |
contracts/Referral.sol
Outdated
| function claim(bytes calldata hash, uint8 v, bytes32 r, bytes32 s) external { | ||
| require(endDate > now, "Callable only before end date"); | ||
| require(!userClaimed[msg.sender], "Already claimed"); | ||
| require(msg.sender == abi.decode(hash, (address))); |
There was a problem hiding this comment.
You don't need to take hash as input. Just use msg.sender as the hash.
| userClaimed[msg.sender] = true; | ||
| bLotToken.mint(msg.sender, refferalAmount); | ||
| } | ||
|
|
There was a problem hiding this comment.
I'd suggest adding a function to change the signer in case the signer gets compromised or something.
There was a problem hiding this comment.
Added a function to update signer address
test/24_Refferal.test.js
Outdated
| let signedHash = (await web3.eth.accounts.sign(hash, adminPrivateKey)); | ||
|
|
||
| await refferal.claim(hash, signedHash.v, signedHash.r, signedHash.s, {from:user2}); | ||
|
|
There was a problem hiding this comment.
Add asserts to make sure the correct amount of blot were minted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refferal amount can be claimed if the data is signed by the pre defined signer address.