-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix remove query string inclusion in body class generation logic #6547
Bugfix remove query string inclusion in body class generation logic #6547
Conversation
✅ Deploy Preview for plone-components canceled.
|
Need Review @stevepiercy @Wagner3UB @sneridagh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request! This needs review by the @plone/volto-team, but it looks good to me.
Co-authored-by: Steve Piercy <[email protected]>
e3d1b84
to
93cbb0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
News LGTM! Thank you for the quick response.
@stevepiercy Glad to hear that! Let me know if there's anything else needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could still produce a weird class if the querystring has both type and some other parameters, but it's definitely an improvement.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
After fix body class only include the ?type= query_string in is-adding-contenttype class. All other query strings are ignored. If there's no type, no is-adding-contenttype class will be present.
Screenshots after fixing bug:
Closes #6493