Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix remove query string inclusion in body class generation logic #6547

Merged

Conversation

Abhishek-17h
Copy link
Contributor


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

After fix body class only include the ?type= query_string in is-adding-contenttype class. All other query strings are ignored. If there's no type, no is-adding-contenttype class will be present.

Screenshots after fixing bug:
Screenshot from 2024-12-18 21-54-48
Screenshot from 2024-12-18 21-54-24

Closes #6493

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 93cbb0f
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6763fe5aaa63f1000840e167

@Abhishek-17h
Copy link
Contributor Author

Need Review @stevepiercy @Wagner3UB @sneridagh

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! This needs review by the @plone/volto-team, but it looks good to me.

packages/volto/news/6493.bugfix Outdated Show resolved Hide resolved
@Abhishek-17h Abhishek-17h force-pushed the bugfix/bodyclass-querystring-filter branch from e3d1b84 to 93cbb0f Compare December 19, 2024 11:07
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News LGTM! Thank you for the quick response.

@Abhishek-17h
Copy link
Contributor Author

@stevepiercy Glad to hear that! Let me know if there's anything else needed.

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could still produce a weird class if the querystring has both type and some other parameters, but it's definitely an improvement.

@davisagli davisagli merged commit e499f03 into plone:main Dec 19, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is-adding-contenttype bodyclass is dragging the querystring with it
4 participants