Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix precedence of the quanta layer by adding a base layer for all the… #6539

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Fix precedence of the quanta layer by adding a base layer for all the… #6539

merged 4 commits into from
Dec 16, 2024

Conversation

sneridagh
Copy link
Member

@pnicolli I found a bug in the definition of the layers, the quanta plone-components.quanta layer needs to have more priority than the base one. I misunderstood how nested layers worked.

I added a nested plone-components.base layer to all basic components. So, if we want to override declarations in the nested (default) layers, we only have to scope them to the main layer.

Also, I added the ability to setup the layers at the top (Html.jsx component), so we have a "main" centralized entry point to define them in Volto.

@sneridagh
Fix precedence of the quanta layer by adding a base layer for all the…
29abe8a 
… basic components. Added a setting in config object for setting the site's CSS layers.
@netlify Netlify
Copy link

netlify bot commented Dec 14, 2024 •
edited
Loading

✅ Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit fe5b450
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/675da55d358ef9000833dfcf

stevepiercy
stevepiercy requested changes Dec 14, 2024
View reviewed changes
packages/components/src/stories/Introduction.mdx Outdated Show resolved Hide resolved
packages/components/src/stories/Introduction.mdx Outdated Show resolved Hide resolved
packages/components/src/stories/Introduction.mdx Outdated Show resolved Hide resolved
packages/components/src/stories/Introduction.mdx Outdated Show resolved Hide resolved
packages/types/news/6539.feature Outdated Show resolved Hide resolved
packages/components/news/6539.bugfix Outdated Show resolved Hide resolved
docs/source/configuration/settings-reference.md Outdated Show resolved Hide resolved
packages/components/README.md Outdated Show resolved Hide resolved
packages/components/src/stories/Introduction.mdx Outdated Show resolved Hide resolved
packages/components/README.md Outdated Show resolved Hide resolved
stevepiercy
stevepiercy approved these changes Dec 14, 2024
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs and news LGTM.

@sneridagh sneridagh merged commit e0f106a into main Dec 16, 2024
73 checks passed
@sneridagh sneridagh deleted the components-fix-quanta-layer-precedence branch December 16, 2024 17:52
sneridagh added a commit that referenced this pull request Dec 16, 2024
@sneridagh
Merge branch 'main' into plip6321-semanticui-free-cmsui
22f1e5a 
* main:
  Fix precedence of the quanta layer by adding a base layer for all the… (#6539)
  Add monorepo structure to the README (#6542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnicolli pnicolli pnicolli approved these changes

@stevepiercy stevepiercy stevepiercy approved these changes

@davisagli davisagli davisagli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sneridagh @davisagli @stevepiercy @pnicolli