Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the LANGUAGE environment variable in the Docker backend #6231

Merged
merged 14 commits into from
Aug 13, 2024

Conversation

stevepiercy
Copy link
Collaborator

@stevepiercy stevepiercy commented Aug 3, 2024

I also overhauled the multilingual docs and added a new section for the usage of the change in the Makefile.

See #6219 (comment).


📚 Documentation preview 📚: https://volto--6231.org.readthedocs.build/

Copy link

netlify bot commented Aug 3, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 86a40be
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66b278295e709d0008a7a928

@stevepiercy stevepiercy self-assigned this Aug 3, 2024
@stevepiercy stevepiercy added 32 needs: review 99 tag: has docs This pull request has documentation labels Aug 3, 2024
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@wesleybl wesleybl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevepiercy stevepiercy requested a review from davisagli August 6, 2024 06:53
@stevepiercy
Copy link
Collaborator Author

One final review for docs, please. Here's the preview:

https://volto--6231.org.readthedocs.build/contributing/developing-core.html

Copy link
Member

@wesleybl wesleybl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ichim-david ichim-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steve this is all nice to have documented.

@stevepiercy stevepiercy requested a review from davisagli August 6, 2024 20:43
@davisagli davisagli merged commit 8615542 into main Aug 13, 2024
71 checks passed
@davisagli davisagli deleted the set-backend-language branch August 13, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
32 needs: review 99 tag: has docs This pull request has documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants