Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document environment variables #5735
base: main
Are you sure you want to change the base?
Document environment variables #5735
Changes from 3 commits
ffe4126
2c339cb
0a96f4e
3e076c1
a361635
e84cd7e
840af3b
7bd7ce8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these environment variables should follow the existing pattern as the glossary items below.
I also don't know whether the prefix
process.env.
is necessary. Perhaps a Volto core maintainer knows?Finally, do these belong under this heading or another? Again, perhaps a Volto core maintainer knows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevepiercy @Manas-Kenge
process.env.
is not part of the name of the environment variable. It's how the variable is accessed in Node. It doesn't make sense to use it here, which is explaining variables that can be set, not how to write code that uses them.