refactor(auth): Various build improvements and minor refactoring

[rpatterson]

Revert the commits that changed the components that refer to the logged in user to use
the response from the actions API endpoint. IOW, those components now, once again, use
the Bearer token instead. Preserves all the other improvements made to the code along
the way.

The new branch for the plone.restapi includes the API changes to the PAS plugin needed
to set both the Plone classic session cookie and the Bearer token cookie that Volto can
optionally use to initialize authentication without using the Volto login component.

All this put together means that:

• the Volto components related to logged in users now behave largely as they did before
  in terms of interpreting state
• logging in to or out of either classic or Volto also does so in the other

One edge case that remains is when logging in via the Volto UI component as a user from
the Zope root acl_users (e.g. admin or SITE_OWNER_NAME), they aren't logged into
Plone classic. The other direction is fine, logging in as admin to Plone classic
results in a new request to the Volto UI being logged in. Digging into that now.

These changes do not address any of the issues that happen when logged in via the ZMI at
the Zope root. A user logged in that way will still appear logged in to classic Plone,
but won't be recognized by Volto components as logged in but API responses will still
reflect their Manager access rights. Tackling that is coming up.

This PR supersedes both #2535 #2687.

[rpatterson]

For future reference, here's a ./Makefile target I've been using to reproduce upgrade/migration issues with existing ZODBs:

.PHONY: test-upgrades
test-upgrades:  ## Test upgrading existing ZODBs
# Start out before the PR changes
	git checkout master
# Delete and recreate the Zope instance ZODB
	rm -r "./api/.installed.cfg" "./api/var/filestorage/" "./api/var/blobstorage/"
	$(MAKE) build
# Activate job control so back-grounded process get their own PGID so we can kill all
# their descendant processes: https://stackoverflow.com/a/6552484/624787
	set -m
# Start the clean instance
	$(MAKE) start &
	set +x
	until nc -vz "localhost" "3000"; do sleep 1; done
	echo "In the browser, log into the Volto/React UI as the Zope root"
	echo "'/acl_users' user 'admin' to ensure the browser has a JWT token."
	read -p "Hit <ENTER> when done."
	set -x
	kill %1
	while nc -vz "localhost" "3000"; do sleep 1; done
# Force the backend Plone classic UI to be served on the same port so the browser will
# send the same cookies, etc..
	rm -v "./api/.installed.cfg"
	$(MAKE) -C "./api/" INSTANCE_PORT=3000 start &
	set +x
	until nc -vz "localhost" "3000"; do sleep 1; done
	echo "In the browser, visit the Zope root ZMI:"
	echo "http://localhost:3000/manage_main"
	read -p "Hit <ENTER> when done."
	set -x
	kill %1
	while nc -vz "localhost" "3000"; do sleep 1; done
# Checkout the branch that changes the plugins
	git checkout fix-unify-auth
# Start the backend again on the same port, but don't install the `plonesite` part to
# avoid updating/upgrading the ZODB
	cd "./api/"
	"./bin/buildout" instance:http-address=3000 install instance
	"./bin/instance" fg &
	set +x
	until nc -vz "localhost" "3000"; do sleep 1; done
	echo "In the browser, visit the Zope root ZMI:"
	echo "http://localhost:3000/manage_main"
	read -p "Hit <ENTER> when done."
	set -x
	kill %1

[netlify]

✅ Deploy Preview for volto canceled.

Name	Link
🔨 Latest commit	813ba72
🔍 Latest deploy log	https://app.netlify.com/sites/volto/deploys/62566f059dc805000a9e242d

[rpatterson]

mag Inspect the deploy log: https://app.netlify.com/sites/volto/deploys/6218aeab225ab70008a1c0a6

The error message there is about a missing ./Makefile target, netlify, but from the logs I can't see any changes of mine that could have removed such a target. Can someone help me understand how my changes might have affected that or may I ignore that message?

[stevepiercy]

Minor grammar and typo fixes, and attempt to improve docstring for arrayWIdsToObject.

[stevepiercy]

mag Inspect the deploy log: https://app.netlify.com/sites/volto/deploys/6218aeab225ab70008a1c0a6

The error message there is about a missing ./Makefile target, netlify, but from the logs I can't see any changes of mine that could have removed such a target. Can someone help me understand how my changes might have affected that or may I ignore that message?

It fails because the version of the Makefile in this PR does not include the netlify target that was added within the last couple of weeks to the master branch to preview the build of docs.

You could ignore it, but it might be a good idea to rebase your branch on master, then force push, or merge master onto your branch then push, in order to get any of the goodies that have come through in the last two months since opening this PR.

[rpatterson]

It fails because the version of the Makefile in this PR does not include the netlify target that was added within the last couple of weeks to the master branch to preview the build of docs.

Doh! I should have checked for new commits on master before asking for help there, sorry! Thanks for the helping hand. I've merged and pushed.

[stevepiercy]

Suggestions for improving the function name.

[stevepiercy]

I pushed commit ffc731e for review.

I also commented on the function name: #2959 (comment)

[avoinea]

LGTM.

Tested on localhost and demo website with LDAP:

• Plone: 6.0.0a3
• PlonePAS: 7.0.0a3
• plone.restapi "fix-unify-auth-logout":feat(auth): Sync classic/API PAS plugin cookies plone.restapi#1303
• plone.restapi "fix-zope-root-auth":fix(auth): Unify Zope root ZMI w/ API log in/out plone.restapi#1304

[rpatterson]

I can't find any discussion of the why for this change. Am I missing that somewhere?