Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Steve Piercy <[email protected]>
  • Loading branch information
sneridagh and stevepiercy authored Dec 14, 2024
1 parent 8c1bf9a commit fe5b450
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion docs/source/configuration/settings-reference.md
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ querystringSearchGet
Please test this setting properly before enabling in a production site.
cssLayers
If you want to use CSS layers in Volto styling, it's possible to define them making sure that they are defined and applied at the very top level of the page (head tag).
To use CSS layers when styling Volto, you can define and apply them at the very top level of the page, where they appear in the `<head>` tag.
By using this configuration, you can pass the layer list definition as an array:
```js
Expand Down
4 changes: 2 additions & 2 deletions packages/components/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,15 @@ You can override them in your classes while maintaining them for others.

### CSS layers

This package use CSS layers to provide a way to style the components in a more flexible way.
This package uses CSS layers to style the components in a more flexible way.
It uses the `plone-components` layer name to scope all the CSS declarations in the package.
The basic styling uses the nested `plone-components.base` named layer.
You can use the `plone-components` layer to override the basic styling, or use the `plone-components.base` layer to override the basic styling in a more specific way.

### Quanta

This package also features the Quanta components.
These components use the basic styling as a baseline, extending them to achieve Quanta look and feel.
These components use the basic styling as a baseline, extending them to achieve the Quanta look and feel.
They also extend the basic React components in a composable way.
The Quanta styling is scoped in the `plone-components.quanta` named layer.

Expand Down
2 changes: 1 addition & 1 deletion packages/components/news/6539.bugfix
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Fixed precedence of the quanta layer by adding a base layer for all the basic components. @sneridagh
Fixed precedence of the Quanta layer by adding a base layer for all the basic components. @sneridagh
10 changes: 5 additions & 5 deletions packages/components/src/stories/Introduction.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ The purpose of this package is to provide an agnostic set of baseline components

## Usage

Using the package manager of your choice (npm, yarn, pnpm) to install the package in your app.
Use pnpm in case you are adding them a Volto add-on/workspace:
You can use your choice of package manager (npm, yarn, or pnpm) to install the package in your app.
If you add the components to a Volto add-on or workspace, use pnpm, as shown.

```shell
pnpm add @plone/components
Expand Down Expand Up @@ -56,15 +56,15 @@ import '@plone/components/src/styles/basic/TextField.css';

### CSS layers

This package use CSS layers to provide a way to style the components in a more flexible way.
This package uses CSS layers to style the components in a more flexible way.
It uses the `plone-components` layer name to scope all the CSS declarations in the package.
The basic styling uses the nested `plone-components.base` named layer.
You can use the `plone-components` layer to override the basic styling, or use the `plone-components.base` layer to override the basic styling in a more specific way.

## Quanta
### Quanta

This package also features the Quanta components.
These components use the basic styling as a baseline, extending them to achieve Quanta look and feel.
These components use the basic styling as a baseline, extending them to achieve the Quanta look and feel.
They also extend the basic React components in a composable way.
The Quanta styling is scoped in the `plone-components.quanta` named layer.

Expand Down
2 changes: 1 addition & 1 deletion packages/types/news/6539.feature
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Added the type for a setting in config object for setting the site's CSS layers. @sneridagh
Added the typing for the new `cssLayers` configuration object setting. @sneridagh
2 changes: 1 addition & 1 deletion packages/volto/news/6539.feature
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Added a setting in config object for setting the site's CSS layers, if required. @sneridagh
Added a setting in the `config` object to set the site's CSS layers, if required. @sneridagh

0 comments on commit fe5b450

Please sign in to comment.