Merge branch 'main' into erral-registration-form-with-userschema

PACKAGES.md

@@ -2,17 +2,37 @@
 
 This document describes the packages that come with Volto, the default frontend for Plone 6.
 
+These packages are part of Plone's API-first story.
+Most of them are experimental and are marked in their respective `README` files.
+Plone 6.1.x (Volto 18) depends on:
+- `@plone/registry`
+- `@plone/scripts`
+- `@plone/volto-slate`
+
+and as a development dependency:
+- `@plone/types`
+
+Plone 6.0.x (Volto 17 and below) does not use any of them.
+
+These packages are expected to be used and become part of Plone 7.
+Some of them might become part of Plone 6.1.x minor versions.
+
+The packages are divided into three categories or types:
+
+- core
+- utilities
+- add-ons
+
 
 ## `@plone/types`
 
 Plone types is a special development package.
 It contains the Plone typings for TypeScript.
-It's considered a core package, and it's the only package that the other core packages can rely on as
-a `devDependency` in your project configuration.
+It's considered a core package, and it's the only package that the other core packages can rely on as a `devDependency` in your project configuration.
 
 This package contains `.d.ts` typing definitions, curated by hand.
-Due to the nature of this package, it does not need bundling.
-It's published "as is", so you can import the type definitions from anywhere in your code.
+Due to the nature of this package, it does not need to be built nor bundled.
+It is published "as is", so you can import the type definitions from anywhere in your code.
 
 
 ## Core packages
@@ -29,12 +49,10 @@ They must be published and bundled in a traditional (transpiled) way.
 The bundle of these packages must work on both CommonJS and ECMAScript Module (ESM) environments.
 
 
-## Utility packages
+## Utilities packages
 
--   `@plone/drivers`
--   `@plone/helpers`
 -   `@plone/providers`
--   `@plone/rsc`
+-   `@plone/helpers`
 
 
 ### Rules
@@ -44,19 +62,22 @@ They must be published in the traditional way, as a bundle.
 This bundle must work on both CommonJS and ESM environments.
 
 
-## Feature packages
+## Add-on packages
 
 -   `@plone/blocks`
--   `@plone/contents`
 -   `@plone/slots`
+-   `@plone/theming`
+-   `@plone/contents`
 
 
 ### Rules
 
-Feature packages, or add-on packages, can depend on any other package.
+Add-on or feature packages, can depend on any other package.
 You must distribute them as source code, and not transpile them.
 They must provide a default configuration registry loader as the default main entry point export.
-They must be loadable as any other add-on.
+Unlike Volto add-ons, do *NOT* place the code in the `src` folder.
+If you do not transpile the package, the direct resolution must work out of the box, where both the bundler and TypeScript resolution are direct.
+They must be loadable as any other add-on, and contain an add-on registry compatible `install`-able default export.
 
 
 ## Development utility packages

packages/volto-slate/news/6520.internal

@@ -0,0 +1 @@
+Fix extension in files containing JSX. @sneridagh

packages/volto/.eslintrc.core.js

@@ -11,6 +11,7 @@ if (process.env.VOLTOCONFIG) {
   rules = null;
 } else {
   rules = {
+    'react/jsx-filename-extension': ['warn', { extensions: ['.tsx', '.jsx'] }],
     'no-restricted-imports': [
       'warn',
       {

packages/volto/news/6515.bugfix

@@ -0,0 +1 @@
+Fixes ICS download in non-public event content. @sneridagh

packages/volto/news/6520.internal

@@ -0,0 +1 @@
+Fix extension in files containing JSX. @sneridagh

packages/volto/src/components/theme/EventDetails/EventDetails.jsx

@@ -6,7 +6,7 @@ import {
   Recurrence,
 } from '@plone/volto/components/theme/View/EventDatesInfo';
 import Icon from '@plone/volto/components/theme/Icon/Icon';
-import { expandToBackendURL } from '@plone/volto/helpers/Url/Url';
+import { flattenToAppURL } from '@plone/volto/helpers/Url/Url';
 
 import calendarSVG from '@plone/volto/icons/calendar.svg';
 
@@ -147,7 +147,7 @@ const EventDetails = ({ content, display_as = 'aside' }) => {
           className="ics-download"
           target="_blank"
           rel="noreferrer"
-          href={`${expandToBackendURL(content['@id'])}/ics_view`}
+          href={`${flattenToAppURL(content['@id'])}/ics_view`}
         >
           {intl.formatMessage(messages.downloadEvent)}
         </a>

packages/volto/src/components/theme/EventDetails/__snapshots__/EventDetails.test.jsx.snap

@@ -127,7 +127,7 @@ exports[`renders event details component with all props 1`] = `
     />
     <a
       className="ics-download"
-      href="http://localhost:8080/Plone/++api++/my-page/ics_view"
+      href="/my-page/ics_view"
       rel="noreferrer"
       target="_blank"
     >
@@ -169,7 +169,7 @@ exports[`renders event details component with only required props 1`] = `
     />
     <a
       className="ics-download"
-      href="http://localhost:8080/Plone/++api++/my-page/ics_view"
+      href="/my-page/ics_view"
       rel="noreferrer"
       target="_blank"
     >
@@ -211,7 +211,7 @@ exports[`renders event details component without links to api in the text 1`] =
     />
     <a
       className="ics-download"
-      href="http://localhost:8080/Plone/++api++/my-page/ics_view"
+      href="/my-page/ics_view"
       rel="noreferrer"
       target="_blank"
     >

packages/volto/src/components/theme/View/__snapshots__/EventView.test.jsx.snap

@@ -251,7 +251,7 @@ exports[`renders an event view component with all props 1`] = `
           />
           <a
             className="ics-download"
-            href="http://localhost:8080/Plone/++api++/my-page/ics_view"
+            href="/my-page/ics_view"
             rel="noreferrer"
             target="_blank"
           >
@@ -357,7 +357,7 @@ exports[`renders an event view component with only required props 1`] = `
           />
           <a
             className="ics-download"
-            href="http://localhost:8080/Plone/++api++/my-page/ics_view"
+            href="/my-page/ics_view"
             rel="noreferrer"
             target="_blank"
           >
@@ -458,7 +458,7 @@ exports[`renders an event view component without links to api in the text 1`] =
           />
           <a
             className="ics-download"
-            href="http://localhost:8080/Plone/++api++/my-page/ics_view"
+            href="/my-page/ics_view"
             rel="noreferrer"
             target="_blank"
           >

packages/volto/src/express-middleware/files.js

@@ -30,7 +30,10 @@ function filesMiddlewareFn(req, res, next) {
 export default function filesMiddleware() {
   const middleware = express.Router();
 
-  middleware.all(['**/@@download/*', '**/@@display-file/*'], filesMiddlewareFn);
+  middleware.all(
+    ['**/@@download/*', '**/@@display-file/*', '**/ics_view'],
+    filesMiddlewareFn,
+  );
   middleware.id = 'filesResourcesProcessor';
   return middleware;
 }