Fixes ICS download in non-public event content (#6497)

plone · Dec 7, 2024 · b8d12f0 · b8d12f0
1 parent bb2c18c
commit b8d12f0
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 9 deletions.
diff --git a/news/6497.bugfix b/news/6497.bugfix
@@ -0,0 +1 @@
+Fixes ICS download in non-public event content. @sneridagh
diff --git a/src/components/theme/EventDetails/EventDetails.jsx b/src/components/theme/EventDetails/EventDetails.jsx
@@ -6,7 +6,7 @@ import {
   Recurrence,
 } from '@plone/volto/components/theme/View/EventDatesInfo';
 import { Icon } from '@plone/volto/components';
-import { expandToBackendURL } from '@plone/volto/helpers';
+import { flattenToAppURL } from '@plone/volto/helpers';
 
 import calendarSVG from '@plone/volto/icons/calendar.svg';
 
@@ -147,7 +147,7 @@ const EventDetails = ({ content, display_as = 'aside' }) => {
           className="ics-download"
           target="_blank"
           rel="noreferrer"
-          href={`${expandToBackendURL(content['@id'])}/ics_view`}
+          href={`${flattenToAppURL(content['@id'])}/ics_view`}
         >
           {intl.formatMessage(messages.downloadEvent)}
         </a>

diff --git a/src/components/theme/EventDetails/__snapshots__/EventDetails.test.jsx.snap b/src/components/theme/EventDetails/__snapshots__/EventDetails.test.jsx.snap
@@ -127,7 +127,7 @@ exports[`renders event details component with all props 1`] = `
     />
     <a
       className="ics-download"
-      href="http://localhost:8080/Plone/++api++/my-page/ics_view"
+      href="/my-page/ics_view"
       rel="noreferrer"
       target="_blank"
     >
@@ -169,7 +169,7 @@ exports[`renders event details component with only required props 1`] = `
     />
     <a
       className="ics-download"
-      href="http://localhost:8080/Plone/++api++/my-page/ics_view"
+      href="/my-page/ics_view"
       rel="noreferrer"
       target="_blank"
     >
@@ -211,7 +211,7 @@ exports[`renders event details component without links to api in the text 1`] =
     />
     <a
       className="ics-download"
-      href="http://localhost:8080/Plone/++api++/my-page/ics_view"
+      href="/my-page/ics_view"
       rel="noreferrer"
       target="_blank"
     >

diff --git a/src/components/theme/View/__snapshots__/EventView.test.jsx.snap b/src/components/theme/View/__snapshots__/EventView.test.jsx.snap
@@ -251,7 +251,7 @@ exports[`renders an event view component with all props 1`] = `
           />
           <a
             className="ics-download"
-            href="http://localhost:8080/Plone/++api++/my-page/ics_view"
+            href="/my-page/ics_view"
             rel="noreferrer"
             target="_blank"
           >
@@ -357,7 +357,7 @@ exports[`renders an event view component with only required props 1`] = `
           />
           <a
             className="ics-download"
-            href="http://localhost:8080/Plone/++api++/my-page/ics_view"
+            href="/my-page/ics_view"
             rel="noreferrer"
             target="_blank"
           >
@@ -458,7 +458,7 @@ exports[`renders an event view component without links to api in the text 1`] =
           />
           <a
             className="ics-download"
-            href="http://localhost:8080/Plone/++api++/my-page/ics_view"
+            href="/my-page/ics_view"
             rel="noreferrer"
             target="_blank"
           >

diff --git a/src/express-middleware/files.js b/src/express-middleware/files.js
@@ -29,7 +29,10 @@ function filesMiddlewareFn(req, res, next) {
 export default function filesMiddleware() {
   const middleware = express.Router();
 
-  middleware.all(['**/@@download/*', '**/@@display-file/*'], filesMiddlewareFn);
+  middleware.all(
+    ['**/@@download/*', '**/@@display-file/*', '**/ics_view'],
+    filesMiddlewareFn,
+  );
   middleware.id = 'filesResourcesProcessor';
   return middleware;
 }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fixes ICS download in non-public event content. @sneridagh