Add missing for-attribute and (hidden) label to input (#6249)

plone · Aug 23, 2024 · 85f08bc · 85f08bc
1 parent 913670f
commit 85f08bc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/packages/components/news/6249.fix b/packages/components/news/6249.fix
@@ -0,0 +1 @@
+Add missing `for` attribute to checkbox label to improve accessibility. @gomez
diff --git a/packages/volto/src/components/manage/Blocks/Search/components/CheckboxFacet.jsx b/packages/volto/src/components/manage/Blocks/Search/components/CheckboxFacet.jsx
@@ -21,8 +21,10 @@ const CheckboxFacet = (props) => {
         {choices.map(({ label, value }, i) => (
           <div className="entry" key={value}>
             <Checkbox
+              id={value}
               disabled={isEditMode}
               label={label}
+              htmlFor={value}
               radio={!isMulti}
               checked={
                 isMulti
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Add missing `for` attribute to checkbox label to improve accessibility. @gomez